lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2025101452-legacy-gizzard-5bd0@gregkh>
Date: Tue, 14 Oct 2025 07:14:27 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Vincent Liu <vincent.liu@...anix.com>
Cc: dakr@...nel.org, linux-kernel@...r.kernel.org, rafael@...nel.org,
	bhelgaas@...gle.com, linux-pci@...r.kernel.org
Subject: Re: [PATCH v2] driver core: Check drivers_autoprobe for all added
 devices

On Mon, Oct 13, 2025 at 07:14:59PM +0100, Vincent Liu wrote:
> When a device is hot-plugged, the drivers_autoprobe sysfs attribute is
> not checked. This means that drivers_autoprobe is not working as
> intended, e.g. hot-plugged PCIe devices will still be autoprobed and
> bound to drivers even with drivers_autoprobe disabled.
> 
> Make sure all devices check drivers_autoprobe by pushing the
> drivers_autoprobe check into device_initial_probe. This will only
> affect devices on the PCI bus for now as device_initial_probe is only
> called by pci_bus_add_device and bus_probe_device (but bus_probe_device
> already checks for autoprobe). In particular for the PCI devices, only
> hot-plugged PCIe devices/VFs should be affected as the default value of
> pci/drivers_autoprobe remains 1 and can only be cleared from userland.
> 
> Any future callers of device_initial_probe will respsect the
> drivers_autoprobe sysfs attribute, but this should be the intended
> purpose of drivers_autoprobe.
> 
> Signed-off-by: Vincent Liu <vincent.liu@...anix.com>
> ---
> v1->v2: Change commit subject to include driver core (no code change)
> 	https://lore.kernel.org/20251001151508.1684592-1-vincent.liu@nutanix.com

What commit id does this fix?  What devices cause this to happen today
that are seeing this issue?  Should this be backported to older kernels?

thanks,

greg k-h

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ