linux-kernel - Re: [PATCH v2 1/1] samples/bpf: Fix spelling typo in samples/bpf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2240784.irdbgypaU6@7950hx>
Date: Tue, 14 Oct 2025 14:48:19 +0800
From: Menglong Dong <menglong.dong@...ux.dev>
To: Chu Guangqing <chuguangqing@...pur.com>
Cc: ast@...nel.org, daniel@...earbox.net, andrii@...nel.org,
 martin.lau@...ux.dev, eddyz87@...il.com, song@...nel.org,
 yonghong.song@...ux.dev, john.fastabend@...il.com, kpsingh@...nel.org,
 sdf@...ichev.me, haoluo@...gle.com, jolsa@...nel.org, kwankhede@...dia.com,
 bpf@...r.kernel.org, linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
 Chu Guangqing <chuguangqing@...pur.com>
Subject: Re: [PATCH v2 1/1] samples/bpf: Fix spelling typo in samples/bpf

On 2025/10/14 14:08, Chu Guangqing wrote:
> do_hbm_test.sh:
> The comment incorrectly used "upcomming" instead of "upcoming".
> 
> hbm.c
> The comment incorrectly used "Managment" instead of "Management".
> The comment incorrectly used "Currrently" instead of "Currently".
> 
> tcp_cong_kern.c
> The comment incorrectly used "deteremined" instead of "determined".
> 
> tracex1.bpf.c
> The comment incorrectly used "loobpack" instead of "loopback".
> 
> mtty.c
> The comment incorrectly used "atleast" instead of "at least".
> 
> Signed-off-by: Chu Guangqing <chuguangqing@...pur.com>

Hi, Guangqing.

The change log is preferred when you send a new version, which
can make people know the difference in this version quickly. It
could follow the SOB like this:

Signed-off-by: Chu Guangqing <chuguangqing@...pur.com>
---
v2:
- xxx
---

The content that wrapped by the "---" will not be visible after the
patch being applied, so you can put whatever you want here.

> ---
>  samples/bpf/do_hbm_test.sh  | 2 +-
>  samples/bpf/hbm.c           | 4 ++--
>  samples/bpf/tcp_cong_kern.c | 2 +-
>  samples/bpf/tracex1.bpf.c   | 2 +-
>  samples/vfio-mdev/mtty.c    | 2 +-

You titled the patch "samples/bpf: Fix spelling typo in samples/bpf",
but this file is not in the samples/bpf, right? So I think we'd better
split it out.

And it's preferred to tag you patch with "bpf" or "bpf-next", such
as [PATCH bpf-next V2], so the CI can run some testings for you,
even though it's not necessary for this patch.

BTW, "Guangqing Chu" will be better, according to the habit :)

Thanks!
Menglong Dong

>  5 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/samples/bpf/do_hbm_test.sh b/samples/bpf/do_hbm_test.sh
> index 38e4599350db..7f4f722787d5 100755
> --- a/samples/bpf/do_hbm_test.sh
> +++ b/samples/bpf/do_hbm_test.sh
> @@ -112,7 +112,7 @@ function start_hbm () {
>  processArgs () {
>    for i in $args ; do
>      case $i in
> -    # Support for upcomming ingress rate limiting
> +    # Support for upcoming ingress rate limiting
>      #in)         # support for upcoming ingress rate limiting
>      #  dir="-i"
>      #  dir_name="in"
> diff --git a/samples/bpf/hbm.c b/samples/bpf/hbm.c
> index bf66277115e2..fc88d4dbdf48 100644
> --- a/samples/bpf/hbm.c
> +++ b/samples/bpf/hbm.c
> @@ -5,7 +5,7 @@
>   * modify it under the terms of version 2 of the GNU General Public
>   * License as published by the Free Software Foundation.
>   *
> - * Example program for Host Bandwidth Managment
> + * Example program for Host Bandwidth Management
>   *
>   * This program loads a cgroup skb BPF program to enforce cgroup output
>   * (egress) or input (ingress) bandwidth limits.
> @@ -24,7 +24,7 @@
>   *		beyond the rate limit specified while there is available
>   *		bandwidth. Current implementation assumes there is only
>   *		NIC (eth0), but can be extended to support multiple NICs.
> - *		Currrently only supported for egress.
> + *		Currently only supported for egress.
>   *    -h	Print this info
>   *    prog	BPF program file name. Name defaults to hbm_out_kern.o
>   */
> diff --git a/samples/bpf/tcp_cong_kern.c b/samples/bpf/tcp_cong_kern.c
> index 2311fc9dde85..339415eac477 100644
> --- a/samples/bpf/tcp_cong_kern.c
> +++ b/samples/bpf/tcp_cong_kern.c
> @@ -5,7 +5,7 @@
>   * License as published by the Free Software Foundation.
>   *
>   * BPF program to set congestion control to dctcp when both hosts are
> - * in the same datacenter (as deteremined by IPv6 prefix).
> + * in the same datacenter (as determined by IPv6 prefix).
>   *
>   * Use "bpftool cgroup attach $cg sock_ops $prog" to load this BPF program.
>   */
> diff --git a/samples/bpf/tracex1.bpf.c b/samples/bpf/tracex1.bpf.c
> index 0ab39d76ff8f..ceedf0b1d479 100644
> --- a/samples/bpf/tracex1.bpf.c
> +++ b/samples/bpf/tracex1.bpf.c
> @@ -20,7 +20,7 @@ SEC("kprobe.multi/__netif_receive_skb_core*")
>  int bpf_prog1(struct pt_regs *ctx)
>  {
>  	/* attaches to kprobe __netif_receive_skb_core,
> -	 * looks for packets on loobpack device and prints them
> +	 * looks for packets on loopback device and prints them
>  	 * (wildcard is used for avoiding symbol mismatch due to optimization)
>  	 */
>  	char devname[IFNAMSIZ];
> diff --git a/samples/vfio-mdev/mtty.c b/samples/vfio-mdev/mtty.c
> index 59eefe2fed10..6cb3e5974990 100644
> --- a/samples/vfio-mdev/mtty.c
> +++ b/samples/vfio-mdev/mtty.c
> @@ -624,7 +624,7 @@ static void handle_bar_read(unsigned int index, struct mdev_state *mdev_state,
>  		u8 lsr = 0;
>  
>  		mutex_lock(&mdev_state->rxtx_lock);
> -		/* atleast one char in FIFO */
> +		/* at least one char in FIFO */
>  		if (mdev_state->s[index].rxtx.head !=
>  				 mdev_state->s[index].rxtx.tail)
>  			lsr |= UART_LSR_DR;
>