linux-kernel - Re: [PATCH] xfs: XFS_ONLINE_SCRUB_STATS should depend on DEBUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdURm_mpK3Pnr=XtUqe2RsqJY_hVR-R797hRSSc0U_0DKg@mail.gmail.com>
Date: Tue, 14 Oct 2025 09:10:03 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: "Darrick J. Wong" <djwong@...nel.org>
Cc: Carlos Maiolino <cem@...nel.org>, linux-xfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] xfs: XFS_ONLINE_SCRUB_STATS should depend on DEBUG_FS

Hi Darrick,

On Mon, 13 Oct 2025 at 18:32, Darrick J. Wong <djwong@...nel.org> wrote:
> On Mon, Oct 13, 2025 at 10:48:46AM +0200, Geert Uytterhoeven wrote:
> > Currently, XFS_ONLINE_SCRUB_STATS selects DEBUG_FS.  However, DEBUG_FS
> > is meant for debugging, and people may want to disable it on production
> > systems.  Since commit 0ff51a1fd786f47b ("xfs: enable online fsck by
> > default in Kconfig")), XFS_ONLINE_SCRUB_STATS is enabled by default,
> > forcing DEBUG_FS enabled too.
> >
> > Fix this by replacing the selection of DEBUG_FS by a dependency on
> > DEBUG_FS, which is what most other options controlling the gathering and
> > exposing of statistics do.
> >
> > Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> > ---
> >  fs/xfs/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/xfs/Kconfig b/fs/xfs/Kconfig
> > index 8930d5254e1da61d..402cf7aad5ca93ab 100644
> > --- a/fs/xfs/Kconfig
> > +++ b/fs/xfs/Kconfig
> > @@ -156,7 +156,7 @@ config XFS_ONLINE_SCRUB_STATS
> >       bool "XFS online metadata check usage data collection"
> >       default y
> >       depends on XFS_ONLINE_SCRUB
> > -     select DEBUG_FS
> > +     depends on DEBUG_FS
>
> Looks ok to me, though I wonder why there are so many "select DEBUG_FS"
> in the kernel?

I think select is OK for pure debug functionality, which is not enabled
unless really wanted; depends on is better for optional features like
statistics, especially if they default to y.

Alternatively, the "default y" could be dropped from
XFS_ONLINE_SCRUB_STATS?

> Reviewed-by: "Darrick J. Wong" <djwong@...nel.org>

Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds