linux-kernel - 回复: [PATCH 11/11] irqchip: Pass platform device to platform drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <ZQ4PR01MB1202DC8FB0383C35D4FD3D10F2EB2@ZQ4PR01MB1202.CHNPR01.prod.partner.outlook.cn>
Date: Tue, 14 Oct 2025 01:11:44 +0000
From: Changhuang Liang <changhuang.liang@...rfivetech.com>
To: Johan Hovold <johan@...nel.org>, Thomas Gleixner <tglx@...utronix.de>
CC: Florian Fainelli <florian.fainelli@...adcom.com>, Shawn Guo
	<shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>, Fabio Estevam
	<festevam@...il.com>, Claudiu Beznea <claudiu.beznea@...on.dev>, Neil
 Armstrong <neil.armstrong@...aro.org>, Kevin Hilman <khilman@...libre.com>,
	Jerome Brunet <jbrunet@...libre.com>, Martin Blumenstingl
	<martin.blumenstingl@...glemail.com>, Geert Uytterhoeven
	<geert+renesas@...der.be>, Magnus Damm <magnus.damm@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject:
 回复: [PATCH 11/11] irqchip: Pass platform device to platform drivers

Hi, Johan

Thanks for the patch.

> The IRQCHIP_PLATFORM_DRIVER macros can be used to convert OF irqchip
> drivers to platform drivers but currently reuse the OF init callback prototype
> that only takes OF nodes as arguments. This forces drivers to do reverse
> lookups of their struct devices during probe if they need them for things like
> dev_printk() and device managed resources.
> 
> Half of the drivers doing reverse lookups also currently fail to release the
> additional reference taken during the lookup, while other drivers have had the
> reference leak plugged in various ways (e.g. using non-intuitive cleanup
> constructs which still confuse static checkers).
> 
> Switch to using a probe callback that takes a platform device as its first
> argument to simplify drivers and plug the remaining (mostly
> benign) reference leaks.
> 
> Fixes: 32c6c054661a ("irqchip: Add Broadcom BCM2712 MSI-X interrupt
> controller")
> Fixes: 70afdab904d2 ("irqchip: Add IMX MU MSI controller driver")
> Fixes: a6199bb514d8 ("irqchip: Add Qualcomm MPM controller driver")
> Signed-off-by: Johan Hovold <johan@...nel.org>

Reviewed-by: Changhuang Liang <changhuang.liang@...rfivetech.com>