linux-kernel - Re: [PATCH next] drm/bridge: synopsys: Fix an error return in dw_dp_video_need_vsc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aO4GGyJLCZEwFYL4@stanley.mountain>
Date: Tue, 14 Oct 2025 11:13:15 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Andy Yan <andyshrk@....com>
Cc: Andy Yan <andy.yan@...k-chips.com>,
	Andrzej Hajda <andrzej.hajda@...el.com>,
	Neil Armstrong <neil.armstrong@...aro.org>,
	Robert Foss <rfoss@...nel.org>,
	Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
	Jonas Karlman <jonas@...boo.se>,
	Jernej Skrabec <jernej.skrabec@...il.com>,
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
	Maxime Ripard <mripard@...nel.org>,
	Thomas Zimmermann <tzimmermann@...e.de>,
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
	Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH next] drm/bridge: synopsys: Fix an error return in
 dw_dp_video_need_vsc_sdp()

On Tue, Sep 02, 2025 at 04:42:41PM +0800, Andy Yan wrote:
> 
> Hello Dan,
> 
> At 2025-09-02 14:33:44, "Dan Carpenter" <dan.carpenter@...aro.org> wrote:
> >This dw_dp_video_need_vsc_sdp() function is type bool so returning
> >-EINVAL means returning true.  Return false instead.
> >
> >Fixes: 86eecc3a9c2e ("drm/bridge: synopsys: Add DW DPTX Controller support library")
> >Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> 
> 
> Reviewed-by: Andy Yan <andyshrk@....com>
> 

Ping?

regards,
dan carpenter

> 
> >---
> > drivers/gpu/drm/bridge/synopsys/dw-dp.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/drivers/gpu/drm/bridge/synopsys/dw-dp.c b/drivers/gpu/drm/bridge/synopsys/dw-dp.c
> >index 9bbfe8da3de0..33be4eae2b20 100644
> >--- a/drivers/gpu/drm/bridge/synopsys/dw-dp.c
> >+++ b/drivers/gpu/drm/bridge/synopsys/dw-dp.c
> >@@ -1149,7 +1149,7 @@ static bool dw_dp_video_need_vsc_sdp(struct dw_dp *dp)
> > 
> > 	state = dw_dp_get_bridge_state(dp);
> > 	if (!state)
> >-		return -EINVAL;
> >+		return false;
> > 
> > 	if (!link->vsc_sdp_supported)
> > 		return false;
> >-- 
> >2.47.2