linux-kernel - Re: [PATCH v5 09/10] PM: EM: Implement em_notify_pd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0c362b01-5f51-4aab-9ad5-a37173fbfe3a@arm.com>
Date: Tue, 14 Oct 2025 09:48:26 +0100
From: Lukasz Luba <lukasz.luba@....com>
To: Changwoo Min <changwoo@...lia.com>
Cc: christian.loehle@....com, tj@...nel.org, pavel@...nel.org,
 len.brown@...el.com, rafael@...nel.org, kernel-dev@...lia.com,
 linux-pm@...r.kernel.org, sched-ext@...ts.linux.dev,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 09/10] PM: EM: Implement em_notify_pd_created/updated()



On 10/14/25 01:10, Changwoo Min wrote:
> Implement two event notifications when a performance domain is created
> (EM_CMD_PD_CREATED) and updated (EM_CMD_PD_UPDATED). The message format
> of these two event notifications is the same as EM_CMD_GET_PD_TABLE --
> containing the performance domain's ID and its energy model table.
> 
> Signed-off-by: Changwoo Min <changwoo@...lia.com>
> ---
>   kernel/power/em_netlink.c | 44 +++++++++++++++++++++++++++++++++++++++
>   kernel/power/em_netlink.h |  6 ++++++
>   2 files changed, 50 insertions(+)
> 
> diff --git a/kernel/power/em_netlink.c b/kernel/power/em_netlink.c
> index 90ae6f1c9c9a..2c55c758de6b 100644
> --- a/kernel/power/em_netlink.c
> +++ b/kernel/power/em_netlink.c
> @@ -215,6 +215,50 @@ int em_nl_get_pd_table_doit(struct sk_buff *skb, struct genl_info *info)
>   
>   
>   /**************************** Event encoding *********************************/
> +static void __em_notify_pd_table(const struct em_perf_domain *pd, int ntf_type)
> +{
> +	struct sk_buff *msg;
> +	int msg_sz, ret = -EMSGSIZE;
> +	void *hdr;
> +
> +	if (!genl_has_listeners(&em_nl_family, &init_net, EM_NLGRP_EVENT))
> +		return;
> +
> +	msg_sz = __em_nl_get_pd_table_size(pd);
> +
> +	msg = genlmsg_new(msg_sz, GFP_KERNEL);
> +	if (!msg)
> +		return;
> +
> +	hdr = genlmsg_put(msg, 0, 0, &em_nl_family, 0, ntf_type);
> +	if (!hdr)
> +		goto out_free_msg;
> +
> +	ret = __em_nl_get_pd_table(msg, pd);
> +	if (ret)
> +		goto out_free_msg;
> +
> +	genlmsg_end(msg, hdr);
> +
> +	genlmsg_multicast(&em_nl_family, msg, 0, EM_NLGRP_EVENT, GFP_KERNEL);
> +
> +	return;
> +
> +out_free_msg:
> +	nlmsg_free(msg);
> +	return;
> +}
> +
> +void em_notify_pd_created(const struct em_perf_domain *pd)
> +{
> +	__em_notify_pd_table(pd, EM_CMD_PD_CREATED);
> +}
> +
> +void em_notify_pd_updated(const struct em_perf_domain *pd)
> +{
> +	__em_notify_pd_table(pd, EM_CMD_PD_UPDATED);
> +}
> +
>   static int __em_notify_pd_deleted_size(const struct em_perf_domain *pd)
>   {
>   	int id_sz = nla_total_size(sizeof(u32)); /* EM_A_PD_TABLE_PD_ID */
> diff --git a/kernel/power/em_netlink.h b/kernel/power/em_netlink.h
> index d56e5865e1ed..583d7f1c3939 100644
> --- a/kernel/power/em_netlink.h
> +++ b/kernel/power/em_netlink.h
> @@ -13,7 +13,9 @@
>   int for_each_em_perf_domain(int (*cb)(struct em_perf_domain*, void *),
>   			    void *data);
>   struct em_perf_domain *em_perf_domain_get_by_id(int id);
> +void em_notify_pd_created(const struct em_perf_domain *pd);
>   void em_notify_pd_deleted(const struct em_perf_domain *pd);
> +void em_notify_pd_updated(const struct em_perf_domain *pd);
>   #else
>   static inline
>   int for_each_em_perf_domain(int (*cb)(struct em_perf_domain*, void *),
> @@ -27,7 +29,11 @@ struct em_perf_domain *em_perf_domain_get_by_id(int id)
>   	return NULL;
>   }
>   
> +static inline void em_notify_pd_created(const struct em_perf_domain *pd) {}
> +
>   static inline void em_notify_pd_deleted(const struct em_perf_domain *pd) {}
> +
> +static inline void em_notify_pd_updated(const struct em_perf_domain *pd) {}
>   #endif
>   
>   #endif /* _EM_NETLINK_H */



Reviewed-by: Lukasz Luba <lukasz.luba@....com>