linux-kernel - Re: [PATCH] sched/deadline: stop dl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aO4Tw1SzNpgWutK8@jlelli-thinkpadt14gen4.remote.csb>
Date: Tue, 14 Oct 2025 11:11:31 +0200
From: Juri Lelli <juri.lelli@...hat.com>
To: Shrikanth Hegde <sshegde@...ux.ibm.com>
Cc: peterz@...radead.org, mingo@...hat.com, vincent.guittot@...aro.org,
	linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
	m.szyprowski@...sung.com, venkat88@...ux.ibm.com,
	jstultz@...gle.com
Subject: Re: [PATCH] sched/deadline: stop dl_server before CPU goes offline

Hello,

On 10/10/25 00:17, Shrikanth Hegde wrote:
> From: Peter Zijlstra (Intel) <peterz@...radead.org>
> 
> IBM CI tool reported kernel warning[1] when running a CPU removal
> operation through drmgr[2]. i.e "drmgr -c cpu -r -q 1"
> 
> WARNING: CPU: 0 PID: 0 at kernel/sched/cpudeadline.c:219 cpudl_set+0x58/0x170
> NIP [c0000000002b6ed8] cpudl_set+0x58/0x170
> LR [c0000000002b7cb8] dl_server_timer+0x168/0x2a0
> Call Trace:
> [c000000002c2f8c0] init_stack+0x78c0/0x8000 (unreliable)
> [c0000000002b7cb8] dl_server_timer+0x168/0x2a0
> [c00000000034df84] __hrtimer_run_queues+0x1a4/0x390
> [c00000000034f624] hrtimer_interrupt+0x124/0x300
> [c00000000002a230] timer_interrupt+0x140/0x320
> 
> Git bisects to: commit 4ae8d9aa9f9d ("sched/deadline: Fix dl_server getting stuck")
> 
> This happens since: 
> - dl_server hrtimer gets enqueued close to cpu offline, when 
>   kthread_park enqueues a fair task.
> - CPU goes offline and drmgr removes it from cpu_present_mask.
> - hrtimer fires and warning is hit.
> 
> Fix it by stopping the dl_server before CPU is marked dead.
> 
> [1]: https://lore.kernel.org/all/8218e149-7718-4432-9312-f97297c352b9@linux.ibm.com/
> [2]: https://github.com/ibm-power-utilities/powerpc-utils/tree/next/src/drmgr
> 
> [sshegde: wrote the changelog and tested it]
> Fixes: 4ae8d9aa9f9d ("sched/deadline: Fix dl_server getting stuck")
> Reported-by: Venkat Rao Bagalkote <venkat88@...ux.ibm.com>
> Closes: https://lore.kernel.org/all/8218e149-7718-4432-9312-f97297c352b9@linux.ibm.com
> Signed-off-by: Peter Zijlstra (Intel) <peterz@...radead.org>
> Signed-off-by: Shrikanth Hegde <sshegde@...ux.ibm.com>
> Tested-by: Marek Szyprowski <m.szyprowski@...sung.com>
> Tested-by: Shrikanth Hegde <sshegde@...ux.ibm.com>

Looks good to me.

Acked-by: Juri Lelli <juri.lelli@...hat.com>

Thanks!
Juri