linux-kernel - Re: [PATCH v6] HID: lg-g15 - Add support for Logitech G13.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <36553po4-qr86-rsn4-7534-6q197q92r6sr@xreary.bet>
Date: Tue, 14 Oct 2025 11:18:32 +0200 (CEST)
From: Jiri Kosina <jikos@...nel.org>
To: "Leo L. Schwab" <ewhac@...ac.org>
cc: Hans de Goede <hansg@...nel.org>, Kate Hsuan <hpa@...hat.com>, 
    Benjamin Tissoires <bentiss@...nel.org>, linux-input@...r.kernel.org, 
    linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6] HID: lg-g15 - Add support for Logitech G13.

On Wed, 17 Sep 2025, Leo L. Schwab wrote:

> The Logitech G13 is a gaming keypad with general-purpose macro keys,
> four LED-backlit macro preset keys, five "menu" keys, backlight toggle
> key, an analog thumbstick, RGB LED backlight, and a monochrome LCD
> display.
> 
> Support input event generation for all keys and the thumbstick, and
> expose all LEDs.
> 
> Signed-off-by: Leo L. Schwab <ewhac@...ac.org>
> Reviewed-by: Hans de Goede <hansg@...nel.org>
> Tested-by: Kate Hsuan <hpa@...hat.com>
> ---
> Changes in v6:
>   - Alter interaction between `brightness` and `brightness_hw_changed`
>     for the backlight as advised by Hans de Goede <hansg@...nel.org>.
>   - On probe, query device for current state of HW backlight toggle;
>     track in `backlight_disabled` and update sysfs.
>   - Ensure non-backlight LED brightnesses report either 0 or 1.
> Changes in v5:
>   - None; resend v4 due to bounced email submission.
> Changes in v4:
>   - Minor changes recommended by Hans de Goede <hansg@...nel.org>.
> Changes in v3:
>   - Re-revise commit message.
>   - Conditionally compile the section depending on
>     CONFIG_LEDS_BRIGHTNESS_HW_CHANGED correctly this time.
>   - Use led-class-multicolor facilities for the RGB backlight.
>   - Changes recommended by Kate Hsuan <hpa@...hat.com>:
>     - Use guard(mutex) construct.
>     - Fix numerous style nits.
> Changes in v2:
>   - Add `#ifdef CONFIG_LEDS_BRIGHTNESS_HW_CHANGED` bracket around new
>     code segment dependent on that feature (fixes test robot build
>     error).
>   - Use `guard(mutex)` construct in new code (existing code left
>     unmodified).
>   - Commit message revised.

Applied to hid.git#for-6.19/logitech, thanks.

-- 
Jiri Kosina
SUSE Labs