linux-kernel - Re: [PATCH 4/5] power: reset: sc27xx: Add support for SC2730 and OF match table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <982105c4-9dbd-47dc-bfc3-ef37a390a14c@linux.alibaba.com>
Date: Tue, 14 Oct 2025 09:44:15 +0800
From: Baolin Wang <baolin.wang@...ux.alibaba.com>
To: Otto Pflüger <otto.pflueger@...cue.de>
Cc: Sebastian Reichel <sre@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Orson Zhai <orsonzhai@...il.com>,
 Chunyan Zhang <zhang.lyra@...il.com>, Lee Jones <lee@...nel.org>,
 linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/5] power: reset: sc27xx: Add support for SC2730 and OF
 match table



On 2025/9/30 13:30, Otto Pflüger wrote:
> On Tue, Sep 30, 2025 at 11:30:16AM +0800, Baolin Wang wrote:
>>
>> If I remember correctly, the original driver supported SC2730 and SC2731
>> chips. Are you sure the current changes are still needed? Have you tested
>> them on the SC2730 chip?
>>
>>
>> config POWER_RESET_SC27XX
>>          tristate "Spreadtrum SC27xx PMIC power-off driver"
>>          depends on MFD_SC27XX_PMIC || COMPILE_TEST
>>          help
>>            This driver supports powering off a system through
>>            Spreadtrum SC27xx series PMICs. The SC27xx series
>>            PMICs includes the SC2720, SC2721, SC2723, SC2730
>>            and SC2731 chips.
> 
> The driver was hard-coded to use registers 0xc2c and 0xdf0. SC2730 has
> different registers, which were added to the downstream version of the
> driver in [1]. I have tested this with a UMS9230 phone which has an
> SC2730 PMIC according to the device tree.
> 
> [1]: https://github.com/MotorolaMobilityLLC/kernel-sprd/commit/6165e1afe3eba33089fecc86767d47af9ab176d6

OK. Thanks.
Reviewed-by: Baolin Wang <baolin.wang@...ux.alibaba.com>