linux-kernel - Re: [PATCH net-next] r8152: Advertise software timestamp information.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4ffafe38-3521-4af6-810b-d9fbfe0e2020@linux.dev>
Date: Tue, 14 Oct 2025 12:05:51 +0100
From: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
To: rawal.abhishek92@...il.com, Andrew Lunn <andrew+netdev@...n.ch>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Cc: arawal@...hat.com, jamie.bainbridge@...il.com, linux-usb@...r.kernel.org,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] r8152: Advertise software timestamp information.

On 14/10/2025 06:52, rawal.abhishek92@...il.com wrote:
> From: Abhishek Rawal <rawal.abhishek92@...il.com>
> 
> Driver calls skb_tx_timestamp(skb) in rtl8152_start_xmit(), but does not advertise the capability in ethtool.
> Advertise software timestamp capabilities on struct ethtool_ops.
> 
> Signed-off-by: Abhishek Rawal <rawal.abhishek92@...il.com>
> Reviewed-by: Jamie Bainbridge <jamie.bainbridge@...il.com>
> ---
>   drivers/net/usb/r8152.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
> index 44cba7acfe7d9bfbcc96a1e974762657bd1c3c33..f896e9f28c3b0ce2282912c9ea37820160df3a45 100644
> --- a/drivers/net/usb/r8152.c
> +++ b/drivers/net/usb/r8152.c
> @@ -9311,6 +9311,7 @@ static const struct ethtool_ops ops = {
>   	.set_ringparam = rtl8152_set_ringparam,
>   	.get_pauseparam = rtl8152_get_pauseparam,
>   	.set_pauseparam = rtl8152_set_pauseparam,
> +	.get_ts_info = ethtool_op_get_ts_info,
>   };
>   
>   static int rtl8152_ioctl(struct net_device *netdev, struct ifreq *rq, int cmd)

Reviewed-by: Vadim Fedorenko <vadim.fedorenko@...ux.dev>