linux-kernel - Re: [PATCH v2] HID: hid-input: only ignore 0 battery events for digitizers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <p7675qor-q8qp-spr8-3o6r-pp3qp42qp4q4@xreary.bet>
Date: Wed, 15 Oct 2025 17:15:18 +0200 (CEST)
From: Jiri Kosina <jikos@...nel.org>
To: Dmitry Torokhov <dmitry.torokhov@...il.com>
cc: Benjamin Tissoires <bentiss@...nel.org>, 
    卢国宏 <luguohong@...omi.com>, kenalba@...gle.com, 
    linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] HID: hid-input: only ignore 0 battery events for
 digitizers

On Tue, 14 Oct 2025, Dmitry Torokhov wrote:

> Commit 581c4484769e ("HID: input: map digitizer battery usage") added
> handling of battery events for digitizers (typically for batteries
> presented in stylii). Digitizers typically report correct battery levels
> only when stylus is actively touching the surface, and in other cases
> they may report battery level of 0. To avoid confusing consumers of the
> battery information the code was added to filer out reports with 0
> battery levels.
> 
> However there exist other kinds of devices that may legitimately report
> 0 battery levels. Fix this by filtering out 0-level reports only for
> digitizer usages, and continue reporting them for other kinds of devices
> (Smart Batteries, etc).
> 
> Reported-by: 卢国宏 <luguohong@...omi.com>
> Fixes: 581c4484769e ("HID: input: map digitizer battery usage")
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
> ---
> 
> v2: rebased on top of linux-next, dropped Tested-by: tag

Applied, thanks!

-- 
Jiri Kosina
SUSE Labs