[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <192bc74d-90d8-45ae-a324-6c29ccae2a06@gmail.com>
Date: Wed, 15 Oct 2025 21:06:58 +0530
From: Ankan Biswas <spyjetfayed@...il.com>
To: bbrezillon@...nel.org, himal.prasad.ghimiray@...el.com, dakr@...nel.org,
matt.coster@...tec.com, robin.clark@....qualcomm.com,
matthew.brost@...el.com, aliceryhl@...gle.com,
thomas.hellstrom@...ux.intel.com
Cc: maarten.lankhorst@...ux.intel.com, mripard@...nel.org,
tzimmermann@...e.de, simona@...ll.ch, skhan@...uxfoundation.org,
khalid@...nel.org, david.hunter.linux@...il.com,
linux-kernel@...r.kernel.org, linux-kernel-mentees@...ts.linux.dev,
dri-devel@...ts.freedesktop.org, Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [PATCH v2] drm/gpuvm: Fix kernel-doc warning for
drm_gpuvm_map_req.map
On 10/15/25 6:56 PM, Matt Coster wrote:
> On 15/10/2025 12:31, Ankan Biswas wrote:
>> The kernel-doc for struct drm_gpuvm_map_req.map was added as '@...map'
>> instead of '@...', leading to this warning during htmldocs build:
>>
>> WARNING: include/drm/drm_gpuvm.h:1083 struct member 'map' not
described in 'drm_gpuvm_map_req'
>>
>> Fixes: 000a45dce7ad ("drm/gpuvm: Pass map arguments through a struct")
>> Reported-by: Stephen Rothwell<sfr@...b.auug.org.au>
>> Signed-off-by: Ankan Biswas<spyjetfayed@...il.com>
> Hi Ankan,
>
> Thanks for the fix! Is there a public report from Stephen that you can
> link to with a Closes: tag after the Reported-by: tag (see [1])?
Hi Matt
Thanks for pointing that out, I have added the Closes tag for v3.
And resent it.
>
> Otherwise, this looks good to me and I'll be happy to R-b and take it
> via drm-misc-fixes.
On 10/15/25 7:09 PM, Danilo Krummrich wrote:
> On 10/15/25 1:31 PM, Ankan Biswas wrote:
>> The kernel-doc for struct drm_gpuvm_map_req.map was added as '@...map'
>> instead of '@...', leading to this warning during htmldocs build:
>>
>> WARNING: include/drm/drm_gpuvm.h:1083 struct member 'map' not
described in 'drm_gpuvm_map_req'
>>
>> Fixes: 000a45dce7ad ("drm/gpuvm: Pass map arguments through a struct")
>> Reported-by: Stephen Rothwell<sfr@...b.auug.org.au>
> Please add a Closes: tag, checkpatch.pl should warn about this.
>
> Thanks,
> Danilo
Hi Danilo,
My bad, I did not use checkpatch.pl before sending, I didn't know
it also caught missing tags. Thanks for mentioning it.
Best Regards,
Ankan Biswas
Powered by blists - more mailing lists