linux-kernel - Re: [PATCH v1 1/4] media: qcom: iris: Add support for scale and improve format alignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a1edafeb-af41-4c96-8c39-a327528e0802@kernel.org>
Date: Wed, 15 Oct 2025 17:00:10 +0100
From: Bryan O'Donoghue <bod@...nel.org>
To: Wangao Wang <wangao.wang@....qualcomm.com>,
 vikash.garodia@....qualcomm.com, dikshita.agarwal@....qualcomm.com,
 abhinav.kumar@...ux.dev, mchehab@...nel.org
Cc: linux-media@...r.kernel.org, linux-arm-msm@...r.kernel.org,
 linux-kernel@...r.kernel.org, quic_qiweil@...cinc.com,
 quic_renjiang@...cinc.com
Subject: Re: [PATCH v1 1/4] media: qcom: iris: Add support for scale and
 improve format alignment

On 15/10/2025 10:27, Wangao Wang wrote:
> Add output width and height settings in iris_venc_s_fmt_output to
> enable scaling functionality.
> 
> Add members enc_raw_width, enc_raw_height, enc_bitstream_width and
> enc_bitstream_height to the struct iris_inst to support codec
> alignment requirements.
> 
> HFI_PROP_CROP_OFFSETS is used to inform the firmware of the region
> of interest, rather than indicating that the codec supports crop.
> Therefore, the crop handling has been corrected accordingly.
> 
> Signed-off-by: Wangao Wang <wangao.wang@....qualcomm.com>

Generally a patch that contains and "and" could be split into two patches.

Please do that here.

- One patch for your alignment changes
- One patch to support scaling

in whatever order is more logical.

---
bod