linux-kernel - Re: [PATCH v3] drm/gpuvm: Fix kernel-doc warning for drm_gpuvm_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <46d01053-c37b-4094-a333-dd12d06f6cde@imgtec.com>
Date: Wed, 15 Oct 2025 16:41:20 +0000
From: Matt Coster <Matt.Coster@...tec.com>
To: Ankan Biswas <spyjetfayed@...il.com>
CC: "bbrezillon@...nel.org" <bbrezillon@...nel.org>,
        "himal.prasad.ghimiray@...el.com" <himal.prasad.ghimiray@...el.com>,
        "dakr@...nel.org" <dakr@...nel.org>,
        "robin.clark@....qualcomm.com"
	<robin.clark@....qualcomm.com>,
        "matthew.brost@...el.com"
	<matthew.brost@...el.com>,
        "aliceryhl@...gle.com" <aliceryhl@...gle.com>,
        "thomas.hellstrom@...ux.intel.com" <thomas.hellstrom@...ux.intel.com>,
        "maarten.lankhorst@...ux.intel.com" <maarten.lankhorst@...ux.intel.com>,
        "mripard@...nel.org" <mripard@...nel.org>,
        "tzimmermann@...e.de"
	<tzimmermann@...e.de>,
        "simona@...ll.ch" <simona@...ll.ch>,
        "skhan@...uxfoundation.org" <skhan@...uxfoundation.org>,
        "khalid@...nel.org"
	<khalid@...nel.org>,
        "david.hunter.linux@...il.com"
	<david.hunter.linux@...il.com>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>,
        "linux-kernel-mentees@...ts.linux.dev"
	<linux-kernel-mentees@...ts.linux.dev>,
        "dri-devel@...ts.freedesktop.org"
	<dri-devel@...ts.freedesktop.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [PATCH v3] drm/gpuvm: Fix kernel-doc warning for
 drm_gpuvm_map_req.map

On 15/10/2025 16:20, Ankan Biswas wrote:
> The kernel-doc for struct drm_gpuvm_map_req.map was added as '@...map'
> instead of '@...', leading to this warning during htmldocs build:
> 
> WARNING: include/drm/drm_gpuvm.h:1083 struct member 'map' not described in 'drm_gpuvm_map_req'
> 
> Fixes: 000a45dce7ad ("drm/gpuvm: Pass map arguments through a struct")
> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> Closes: https://lore.kernel.org/all/20250821133539.03aa298e@canb.auug.org.au/ 
> Signed-off-by: Ankan Biswas <spyjetfayed@...il.com>

Hi Ankan,

Thanks for the updated patch! All looks good to me, so:

Reviewed-by: Matt Coster <matt.coster@...tec.com>

No need to send a v4 adding my tag, it'll get picked up when I apply to
drm-misc-fixes on Friday (assuming nobody has any objections).

Cheers,
Matt

> ---
> Changes in v3:
> -  Addled Closes tag in log
> 
> Changes in v2:
> - typos fixed 'map_ops' -> '@...map', 'map' -> '@...'
> 
>  include/drm/drm_gpuvm.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/drm/drm_gpuvm.h b/include/drm/drm_gpuvm.h
> index 8890ded1d907..476990e761f8 100644
> --- a/include/drm/drm_gpuvm.h
> +++ b/include/drm/drm_gpuvm.h
> @@ -1078,7 +1078,7 @@ struct drm_gpuva_ops {
>   */
>  struct drm_gpuvm_map_req {
>  	/**
> -	 * @op_map: struct drm_gpuva_op_map
> +	 * @map: struct drm_gpuva_op_map
>  	 */
>  	struct drm_gpuva_op_map map;
>  };

-- 
Matt Coster
E: matt.coster@...tec.com


Download attachment "OpenPGP_signature.asc" of type "application/pgp-signature" (237 bytes)