linux-kernel - Re: [PATCH RFC net-next] net: drop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aO_Qs9jzbguNrTjV@horms.kernel.org>
Date: Wed, 15 Oct 2025 17:49:55 +0100
From: Simon Horman <horms@...nel.org>
To: Florian Westphal <fw@...len.de>
Cc: Eric Dumazet <edumazet@...gle.com>, Wang Liang <wangliang74@...wei.com>,
	nhorman@...driver.com, davem@...emloft.net, kuba@...nel.org,
	pabeni@...hat.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, yuehaibing@...wei.com,
	zhangchangzhong@...wei.com
Subject: Re: [PATCH RFC net-next] net: drop_monitor: Add debugfs support

On Wed, Oct 15, 2025 at 01:14:47PM +0200, Florian Westphal wrote:
> Eric Dumazet <edumazet@...gle.com> wrote:
> > I do not understand the fascination with net/core/drop_monitor.c,
> > which looks very old school to me,
> > and misses all the features,  flexibility, scalability  that 'perf',
> > eBPF tracing, bpftrace, .... have today.
> > 
> > Adding  /sys/kernel/debug/drop_monitor/* is even more old school.
> > 
> > Not mentioning the maintenance burden.
> > 
> > For me the choice is easy :
> > 
> > # CONFIG_NET_DROP_MONITOR is not set
> > 
> > perf record -ag -e skb:kfree_skb sleep 1
> > 
> > perf script # or perf report
> 
> Maybe:
> 
> diff --git a/net/Kconfig b/net/Kconfig
> --- a/net/Kconfig
> +++ b/net/Kconfig
> @@ -400,15 +400,15 @@ config NET_PKTGEN
>           module will be called pktgen.
> 
>  config NET_DROP_MONITOR
> -       tristate "Network packet drop alerting service"
> +       tristate "Legacy network packet drop alerting service"

+1

...