linux-kernel - Re: [PATCH v2] dt-bindings: iommu: qcom

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8e7a145e-6871-4974-ae19-40699747803b@arm.com>
Date: Wed, 15 Oct 2025 17:48:05 +0100
From: Robin Murphy <robin.murphy@....com>
To: Konrad Dybcio <konradybcio@...nel.org>, Joerg Roedel <joro@...tes.org>,
 Will Deacon <will@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, iommu@...ts.linux.dev,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 Konrad Dybcio <konrad.dybcio@...aro.org>
Subject: Re: [PATCH v2] dt-bindings: iommu: qcom_iommu: Allow 'tbu' clock

On 2025-10-15 5:41 pm, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@...aro.org>
> 
> Some IOMMUs on some platforms (there doesn't seem to be a good denominator
> for this) require the presence of a third clock, specifically for
> accessing the IOMMU's Translation Buffer Unit (TBU). Allow it.

Hmmm, but isn't the only thing that accesses TBUs the consumer of the 
qcom,tbu binding, which already has its own clock?

Thanks,
Robin.

> Reviewed-by: Rob Herring <robh@...nel.org>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@...aro.org>
> ---
> Resending from a 2023 megaseries, no changes
> 
> v1: https://lore.kernel.org/lkml/20230627-topic-more_bindings-v1-7-6b4b6cd081e5@linaro.org/
> ---
>   Documentation/devicetree/bindings/iommu/qcom,iommu.yaml | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iommu/qcom,iommu.yaml b/Documentation/devicetree/bindings/iommu/qcom,iommu.yaml
> index 3e5623edd207..93a489025317 100644
> --- a/Documentation/devicetree/bindings/iommu/qcom,iommu.yaml
> +++ b/Documentation/devicetree/bindings/iommu/qcom,iommu.yaml
> @@ -32,14 +32,18 @@ properties:
>             - const: qcom,msm-iommu-v2
>   
>     clocks:
> +    minItems: 2
>       items:
>         - description: Clock required for IOMMU register group access
>         - description: Clock required for underlying bus access
> +      - description: Clock required for Translation Buffer Unit access
>   
>     clock-names:
> +    minItems: 2
>       items:
>         - const: iface
>         - const: bus
> +      - const: tbu
>   
>     power-domains:
>       maxItems: 1
> 
> ---
> base-commit: f5450b214b2440192a238d0c4af9f725810f8e01
> change-id: 20251015-topic-qciommu_bindings_fix-3bf3904041b9
> 
> Best regards,