linux-kernel - Re: [PATCH 1/1] dt-bindings: net: dsa: nxp,sja1105: Add optional clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_Jsq+wHG_DW1D_=dR6Q_mwyqFAXKGx771PsqjvW+XCRKM3tw@mail.gmail.com>
Date: Wed, 15 Oct 2025 12:32:14 -0500
From: Rob Herring <robh@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Conor Dooley <conor@...nel.org>, Frank Li <Frank.Li@....com>, Andrew Lunn <andrew@...n.ch>, 
	Vladimir Oltean <olteanv@...il.com>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	"open list:NETWORKING DRIVERS" <netdev@...r.kernel.org>, 
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>, 
	imx@...ts.linux.dev
Subject: Re: [PATCH 1/1] dt-bindings: net: dsa: nxp,sja1105: Add optional clock

On Wed, Oct 15, 2025 at 9:25 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Wed, 15 Oct 2025 06:53:01 -0500 Rob Herring wrote:
> > > > And the issue is that both PW projects might get updated and both don't
> > > > necessarily want the same state (like this case). So we need to
> > > > distinguish. Perhaps like one of the following:
> > > >
> > > > dt-pw-bot: <state>
> > > >
> > > > or
> > > >
> > > > pw-bot: <project> <state>
> > >
> > > We crossed replies, do you mind
> > >
> > >   pw-bot: xyz [project]
> > >
> > > ? I like the optional param after required, and the brackets may help
> > > us disambiguate between optional params if there are more in the future.
> >
> > That's fine. Though it will be optional for you, but not us? We have
> > to ignore tags without the project if tags intended for netdev are
> > continued without the project. Or does no project mean I want to
> > update every project?
>
> Fair :( I imagine your workflow is that patches land in your pw, and
> once a DT maintainer reviewed them you don't care about them any more?

Not exactly. Often I don't, but for example sometimes I need to apply
the patch (probably should setup a group tree, but it's enough of an
exception I haven't.).

> So perhaps a better bot on your end would be a bot which listens to
> Ack/Review tags from DT maintainers. When tag is received the patch
> gets dropped from PW as "Handled Elsewhere", and patch id (or whatever
> that patch hash thing is called) gets recorded to automatically discard
> pure reposts.

I already have that in place too. Well, kind of, it updates my
review/ack automatically on subsequent versions, but I currently do a
separate pass of what Conor and Krzysztof reviewed. Where the pw-bot
tags are useful is when there are changes requested. I suppose I could
look for replies from them without acks, but while that usually
indicates changes are needed, not always. So the pw-bot tag is useful
to say the other DT maintainers don't need to look at this patch at
all.

Rob