linux-kernel - Re: [PATCH v15 0/7] Rust Abstractions for PWM subsystem with TH1520 PWM driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0da1d4cc-1984-4813-9265-7f10aa1542f2@samsung.com>
Date: Wed, 15 Oct 2025 20:07:04 +0200
From: Michal Wilczynski <m.wilczynski@...sung.com>
To: Uwe Kleine-König <ukleinek@...nel.org>
Cc: Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>,
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, Andreas
	Hindborg <a.hindborg@...nel.org>, Alice Ryhl <aliceryhl@...gle.com>, Trevor
	Gross <tmgross@...ch.edu>, Danilo Krummrich <dakr@...nel.org>, Guo Ren
	<guoren@...nel.org>, Fu Wei <wefu@...hat.com>, Rob Herring
	<robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
	<conor+dt@...nel.org>, Paul Walmsley <paul.walmsley@...ive.com>, Palmer
	Dabbelt <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>, Alexandre
	Ghiti <alex@...ti.fr>, Marek Szyprowski <m.szyprowski@...sung.com>, Benno
	Lossin <lossin@...nel.org>, Michael Turquette <mturquette@...libre.com>,
	Drew Fustini <fustini@...nel.org>, Daniel Almeida
	<daniel.almeida@...labora.com>, linux-kernel@...r.kernel.org,
	linux-pwm@...r.kernel.org, rust-for-linux@...r.kernel.org,
	linux-riscv@...ts.infradead.org, devicetree@...r.kernel.org, Elle Rhumsaa
	<elle@...thered-steel.dev>, Krzysztof Kozlowski
	<krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH v15 0/7] Rust Abstractions for PWM subsystem with TH1520
 PWM driver



On 10/15/25 19:52, Michal Wilczynski wrote:
> 
> 
> On 10/13/25 18:48, Uwe Kleine-König wrote:
>>
>> diff --git a/drivers/pwm/pwm_th1520.rs b/drivers/pwm/pwm_th1520.rs
>> index c9fd1d8d17bc..a5666052b7ce 100644
>> --- a/drivers/pwm/pwm_th1520.rs
>> +++ b/drivers/pwm/pwm_th1520.rs
>> @@ -121,6 +121,7 @@ fn round_waveform_tohw(
>>          wf: &pwm::Waveform,
>>      ) -> Result<pwm::RoundedWaveform<Self::WfHw>> {
>>          let data = chip.drvdata();
>> +        let status = 0;
>>  
>>          if wf.period_length_ns == 0 {
>>              dev_dbg!(chip.device(), "Requested period is 0, disabling PWM.\n");
>> @@ -141,18 +142,13 @@ fn round_waveform_tohw(
>>          if period_cycles == 0 {
>>              dev_dbg!(
>>                  chip.device(),
>> -                "Requested period {} ns is too small for clock rate {} Hz, disabling PWM.\n",
>> +                "Requested period {} ns is too small for clock rate {} Hz, rounding up.\n",
>>                  wf.period_length_ns,
>>                  rate_hz
>>              );
>>  
>> -            return Ok(pwm::RoundedWaveform {
>> -                status: 0,
>> -                hardware_waveform: Th1520WfHw {
>> -                    enabled: false,
>> -                    ..Default::default()
>> -                },
>> -            });
>> +            period_cycles = 1;
>> +            status = 1;

Well status and period_cycles need to be mutable obviously, will change
that.


Best regards,
-- 
Michal Wilczynski <m.wilczynski@...sung.com>