linux-kernel - Re: [RFC PATCH] reset: always bail out on missing RESET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aO_jCaplR1xUpj9M@shikoro>
Date: Wed, 15 Oct 2025 20:08:09 +0200
From: Wolfram Sang <wsa+renesas@...g-engineering.com>
To: Philipp Zabel <p.zabel@...gutronix.de>
Cc: linux-renesas-soc@...r.kernel.org,
	Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH] reset: always bail out on missing RESET_GPIO driver

Hi Philipp,

> > On the other hand, the fallback is a really nice feature which could
> > remove duplicated code. But if the fallback is not present by default,
> > it makes it cumbersome to use IMO.
> 
> And it's not easy to automatically determine whether RESET_GPIO is
> actually required, because that depends on both device tree and
> individual drivers.

Well, the driver is small enough to be included always, I'd think.
What about adding this to RESET_GPIO:

	default y if GPIOLIB

?

> In short, if both of_parse_phandle_with_args() return -ENOENT, we
> should continue to silently return (optional ? NULL : -ENOENT), even if
> CONFIG_RESET_GPIO=n.

I think I got it.

> I think the message should be pr_err() level if we return an error that
> will cause the consumer driver probe to fail.

Ok, will send v2 tomorrow.

Thanks for the fast review!

   Wolfram


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)