linux-kernel - Re: [PATCH RFC] nova-core: mm: Add initial structures for page table management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dc510f8e-6c8a-4da4-bfb5-41727c30480f@nvidia.com>
Date: Wed, 15 Oct 2025 16:34:17 -0400
From: Joel Fernandes <joelagnelf@...dia.com>
To: John Hubbard <jhubbard@...dia.com>, linux-kernel@...r.kernel.org,
 rust-for-linux@...r.kernel.org, dri-devel@...ts.freedesktop.org,
 dakr@...nel.org, acourbot@...dia.com
Cc: Alistair Popple <apopple@...dia.com>, Miguel Ojeda <ojeda@...nel.org>,
 Alex Gaynor <alex.gaynor@...il.com>, Boqun Feng <boqun.feng@...il.com>,
 Gary Guo <gary@...yguo.net>, bjorn3_gh@...tonmail.com,
 Benno Lossin <lossin@...nel.org>, Andreas Hindborg <a.hindborg@...nel.org>,
 Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 Timur Tabi <ttabi@...dia.com>, joel@...lfernandes.org,
 Elle Rhumsaa <elle@...thered-steel.dev>,
 Daniel Almeida <daniel.almeida@...labora.com>,
 Andrea Righi <arighi@...dia.com>, nouveau@...ts.freedesktop.org
Subject: Re: [PATCH RFC] nova-core: mm: Add initial structures for page table
 management



On 10/14/2025 10:08 PM, John Hubbard wrote:
> On 10/6/25 2:09 PM, Joel Fernandes wrote:
>> Add initial structures and helpers for page table management. Will
>> expand and build on this in later patches. Uses bitstruct for clean
>> code.
>>
>> Signed-off-by: Joel Fernandes <joelagnelf@...dia.com>
>> ---
>> Rebased on rust-drm-next + bitfield patches [1].
>>
>> [1] https://lore.kernel.org/all/20251003154748.1687160-1-joelagnelf@nvidia.com/
>>
>>  drivers/gpu/nova-core/falcon/gsp.rs |   2 +-
>>  drivers/gpu/nova-core/mm/mod.rs     |   3 +
>>  drivers/gpu/nova-core/mm/types.rs   | 382 ++++++++++++++++++++++++++++
>>  drivers/gpu/nova-core/nova_core.rs  |   1 +
>>  4 files changed, 387 insertions(+), 1 deletion(-)
>>  create mode 100644 drivers/gpu/nova-core/mm/mod.rs
>>  create mode 100644 drivers/gpu/nova-core/mm/types.rs
>>
>
> Hi Joel,
>
> This will be easier to provide a meaningful review for, once there are
> some callers to look at. Structures alone are very difficult to review,
> in the absence of behaviors (callers).

John, true. For next posting of this particular patch, I will post the page
table walker patches as well. There are still several prerequisites that PT
walking needs though (PRAMIN, bitfield, buddy allocator), which I will post in
advance before that. This patch was mainly to show how bitfield (formerly
bitstruct) will be used.

Thanks.