linux-kernel - Re: [PATCH 2/3] rust: pci: move I/O infrastructure to separate file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251015225827.GA960157@bhelgaas>
Date: Wed, 15 Oct 2025 17:58:27 -0500
From: Bjorn Helgaas <helgaas@...nel.org>
To: Danilo Krummrich <dakr@...nel.org>
Cc: bhelgaas@...gle.com, kwilczynski@...nel.org, ojeda@...nel.org,
	alex.gaynor@...il.com, boqun.feng@...il.com, gary@...yguo.net,
	bjorn3_gh@...tonmail.com, lossin@...nel.org, a.hindborg@...nel.org,
	aliceryhl@...gle.com, tmgross@...ch.edu,
	rust-for-linux@...r.kernel.org, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] rust: pci: move I/O infrastructure to separate file

On Wed, Oct 15, 2025 at 08:14:30PM +0200, Danilo Krummrich wrote:
> Move the PCI I/O infrastructure to a separate sub-module in order to
> keep things organized.

> +++ b/rust/kernel/pci/io.rs

> +/// A PCI BAR to perform I/O-Operations on.
> ...
> +/// memory mapped PCI bar and its size.
> ...
> +    /// `ioptr` must be a valid pointer to the memory mapped PCI bar number `num`.

I know this is just a move, but "BAR" vs "bar" usage is inconsistent.
I think "BAR" is clearer in comments.

> +    /// Mapps an entire PCI-BAR after performing a region-request on it. I/O operation bound checks
> ...
> +    /// Mapps an entire PCI-BAR after performing a region-request on it.

Similarly, s/Mapps/Maps/ and s/PCI-BAR/PCI BAR/