linux-kernel - Re: [PATCH v7 10/20] soc: mediatek: mtk-cmdq: Add new APIs to replace cmdq_pkt_write() and cmdq_pkt_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20f251d7b6a345f607c60e703164f6baa8f8afad.camel@mediatek.com>
Date: Wed, 15 Oct 2025 03:47:21 +0000
From: Jason-JH Lin (林睿祥) <Jason-JH.Lin@...iatek.com>
To: "chunkuang.hu@...nel.org" <chunkuang.hu@...nel.org>, "AngeloGioacchino Del
 Regno" <angelogioacchino.delregno@...labora.com>, "robh@...nel.org"
	<robh@...nel.org>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
	"jassisinghbrar@...il.com" <jassisinghbrar@...il.com>, "mchehab@...nel.org"
	<mchehab@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
	CK Hu (胡俊光) <ck.hu@...iatek.com>
CC: "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
	Sirius Wang (王皓昱) <Sirius.Wang@...iatek.com>,
	Nancy Lin (林欣螢) <Nancy.Lin@...iatek.com>,
	Xiandong Wang (王先冬)
	<Xiandong.Wang@...iatek.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "nicolas@...fresne.ca"
	<nicolas@...fresne.ca>, Project_Global_Chrome_Upstream_Group
	<Project_Global_Chrome_Upstream_Group@...iatek.com>,
	"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	Paul-pl Chen (陳柏霖) <Paul-pl.Chen@...iatek.com>,
	Moudy Ho (何宗原) <Moudy.Ho@...iatek.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Singo Chang (張興國) <Singo.Chang@...iatek.com>,
	"wenst@...omium.org" <wenst@...omium.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "matthias.bgg@...il.com"
	<matthias.bgg@...il.com>
Subject: Re: [PATCH v7 10/20] soc: mediatek: mtk-cmdq: Add new APIs to replace
 cmdq_pkt_write() and cmdq_pkt_write_mask()

[snip]

> > > > +
> > > > +int cmdq_pkt_write_mask_subsys(struct cmdq_pkt *pkt, u8
> > > > subsys,
> > > > u32 pa_base /*unused*/,
> > > > +                          u16 offset, u32 value, u32 mask)
> > > 
> > > pa_base is useless. Drop it.
> > > 
> > > > +{
> > > > +   return cmdq_pkt_write_mask(pkt, subsys, offset, value,
> > > > mask);
> > > > +}
> > > > +EXPORT_SYMBOL(cmdq_pkt_write_mask_subsys);
> > > > +
> > 
> > Hi CK,
> > 
> > I'll drop the unused parameters.
> > Thanks for the reviews.
> 
> It's unused, but if we want to use function pointers we do need
> those.
> 
> Unless you want to use one variable for both things, which then
> becomes
> kind of janky and unreadable.
> 

Yes, I encountered this problem when I was editing it yesterday.

I'll keep these unused parameters to make the function pointer
interface aligned and send the next version soon.

Thanks,
Jason-JH Lin

> Cheers,
> Angelo
> 
> > 
> > Regards,
> > Jason-JH Lin