linux-kernel - Re: [PATCH v5 08/10] PM: EM: Implement em_notify_pd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202510151223.THlBK6QR-lkp@intel.com>
Date: Wed, 15 Oct 2025 12:16:10 +0800
From: kernel test robot <lkp@...el.com>
To: Changwoo Min <changwoo@...lia.com>, lukasz.luba@....com,
	rafael@...nel.org, len.brown@...el.com, pavel@...nel.org
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	christian.loehle@....com, tj@...nel.org, kernel-dev@...lia.com,
	linux-pm@...r.kernel.org, sched-ext@...ts.linux.dev,
	linux-kernel@...r.kernel.org, Changwoo Min <changwoo@...lia.com>
Subject: Re: [PATCH v5 08/10] PM: EM: Implement em_notify_pd_deleted()

Hi Changwoo,

kernel test robot noticed the following build warnings:

[auto build test WARNING on amd-pstate/linux-next]
[also build test WARNING on amd-pstate/bleeding-edge linus/master v6.18-rc1 next-20251014]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Changwoo-Min/PM-EM-Assign-a-unique-ID-when-creating-a-performance-domain/20251014-082420
base:   https://git.kernel.org/pub/scm/linux/kernel/git/superm1/linux.git linux-next
patch link:    https://lore.kernel.org/r/20251014001055.772422-9-changwoo%40igalia.com
patch subject: [PATCH v5 08/10] PM: EM: Implement em_notify_pd_deleted()
config: i386-buildonly-randconfig-004-20251015 (https://download.01.org/0day-ci/archive/20251015/202510151223.THlBK6QR-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251015/202510151223.THlBK6QR-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202510151223.THlBK6QR-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> kernel/power/em_netlink.c:228:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
     228 |         int ret = -EMSGSIZE;
         |             ^
   1 warning generated.


vim +/ret +228 kernel/power/em_netlink.c

   224	
   225	void em_notify_pd_deleted(const struct em_perf_domain *pd)
   226	{
   227		struct sk_buff *msg;
 > 228		int ret = -EMSGSIZE;
   229		void *hdr;
   230		int msg_sz;
   231	
   232		if (!genl_has_listeners(&em_nl_family, &init_net, EM_NLGRP_EVENT))
   233			return;
   234	
   235		msg_sz = __em_notify_pd_deleted_size(pd);
   236	
   237		msg = genlmsg_new(msg_sz, GFP_KERNEL);
   238		if (!msg)
   239			return;
   240	
   241		hdr = genlmsg_put(msg, 0, 0, &em_nl_family, 0, EM_CMD_PD_DELETED);
   242		if (!hdr)
   243			goto out_free_msg;
   244	
   245		if (nla_put_u32(msg, EM_A_PD_TABLE_PD_ID, pd->id)) {
   246			ret = -EMSGSIZE;
   247			goto out_free_msg;
   248		}
   249	
   250		genlmsg_end(msg, hdr);
   251	
   252		genlmsg_multicast(&em_nl_family, msg, 0, EM_NLGRP_EVENT, GFP_KERNEL);
   253	
   254		return;
   255	
   256	out_free_msg:
   257		nlmsg_free(msg);
   258		return;
   259	}
   260	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki