linux-kernel - Re: [PATCH] kbuild: uapi: reuse KBUILD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251015001921.GA2263607@ax162>
Date: Tue, 14 Oct 2025 17:19:21 -0700
From: Nathan Chancellor <nathan@...nel.org>
To: Thomas Weißschuh <thomas.weissschuh@...utronix.de>
Cc: Nicolas Schier <nicolas.schier@...ux.dev>, linux-kbuild@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kbuild: uapi: reuse KBUILD_USERCFLAGS

On Tue, Oct 14, 2025 at 07:55:32AM +0200, Thomas Weißschuh wrote:
> The toplevel Makefile already provides the compiler flags necessary to
> build userspace applications for the target.
> 
> Make use of them instead of duplicating the logic.
> 
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@...utronix.de>
> ---

Seems reasonable to me.

Reviewed-by: Nathan Chancellor <nathan@...nel.org>

>  usr/include/Makefile | 11 ++---------
>  1 file changed, 2 insertions(+), 9 deletions(-)
> 
> diff --git a/usr/include/Makefile b/usr/include/Makefile
> index 61a7dd4fc05f004d785c64c0019ad846c84719d5..d8a508042fed315401ed689e0839af249c4b31c8 100644
> --- a/usr/include/Makefile
> +++ b/usr/include/Makefile
> @@ -6,16 +6,9 @@
>  #
>  # -std=c90 (equivalent to -ansi) catches the violation of those.
>  # We cannot go as far as adding -Wpedantic since it emits too many warnings.
> -UAPI_CFLAGS := -std=c90 -Wall -Werror=implicit-function-declaration
> +UAPI_CFLAGS := -std=c90 -Werror=implicit-function-declaration
>  
> -# In theory, we do not care -m32 or -m64 for header compile tests.
> -# It is here just because CONFIG_CC_CAN_LINK is tested with -m32 or -m64.
> -UAPI_CFLAGS += $(filter -m32 -m64 --target=%, $(KBUILD_CPPFLAGS) $(KBUILD_CFLAGS))
> -
> -# USERCFLAGS might contain sysroot location for CC.
> -UAPI_CFLAGS += $(USERCFLAGS)
> -
> -override c_flags = $(UAPI_CFLAGS) -Wp,-MMD,$(depfile) -I $(obj) -I $(srctree)/usr/dummy-include
> +override c_flags = $(KBUILD_USERCFLAGS) $(UAPI_CFLAGS) -Wp,-MMD,$(depfile) -I $(obj) -I $(srctree)/usr/dummy-include
>  
>  # The following are excluded for now because they fail to build.
>  #
> 
> ---
> base-commit: 3a8660878839faadb4f1a6dd72c3179c1df56787
> change-id: 20251013-kbuild-uapi-usercflags-affb222af087
> 
> Best regards,
> -- 
> Thomas Weißschuh <thomas.weissschuh@...utronix.de>
>