Message-ID: <0752fcde-6c25-4cde-b35f-2204e24ff0f1@amd.com>
Date: Wed, 15 Oct 2025 00:13:13 -0500
From: Mario Limonciello <mario.limonciello@....com>
To: Denis Benato <benato.denis96@...il.com>, linux-kernel@...r.kernel.org
Cc: platform-driver-x86@...r.kernel.org, Hans de Goede <hdegoede@...hat.com>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
 "Luke D . Jones" <luke@...nes.dev>, Alok Tiwari <alok.a.tiwari@...cle.com>,
 Derek John Clark <derekjohn.clark@...il.com>,
 Mateusz Schyboll <dragonn@...pl>, porfet828@...il.com
Subject: Re: [PATCH v14 0/9] platform/x86: Add asus-armoury driver



On 10/14/2025 8:47 PM, Denis Benato wrote:
> Hi all,
> 
> the TL;DR:
> 1. Introduce new module to contain bios attributes, using fw_attributes_class
> 2. Deprecate all possible attributes from asus-wmi that were added ad-hoc
> 3. Remove those in the next LTS cycle
> 
> The idea for this originates from a conversation with Mario Limonciello
> https://lore.kernel.org/platform-driver-x86/371d4109-a3bb-4c3b-802f-4ec27a945c99@amd.com/
> 
> It is without a doubt much cleaner to use, easier to discover, and the
> API is well defined as opposed to the random clutter of attributes I had
> been placing in the platform sysfs. Given that Derek is also working on a
> similar approach to Lenovo in part based on my initial work I'd like to think
> that the overall approach is good and may become standardised for these types
> of things.
> 
> Regarding PPT: it is intended to add support for "custom" platform profile
> soon. If it's a blocker for this patch series being accepted I will drop the
> platform-x86-asus-armoury-add-ppt_-and-nv_-tuning.patch and get that done
> separately to avoid holding the bulk of the series up. Ideally I would like
> to get the safe limits in so users don't fully lose functionality or continue
> to be exposed to potential instability from setting too low, or be mislead
> in to thinking they can set limits higher than actual limit.
> 
> The bulk of the PPT patch is data, the actual functional part is relatively
> small and similar to the last version.
> 
> Unfortunately I've been rather busy over the months and may not cover
> everything in the v7 changelog but I've tried to be as comprehensive as I can.
> 
> Regards,
> Luke

As a general comment that applies to a few patches in the series.

The S-o-b means that YOU sign off on them, it's like a chain of custody.

Any patches that you're sending need your own S-o-B, even if they're 
100% the same as the original from Luke.
> 
> Changelog:
> - v1
>    - Initial submission
> - v2
>    - Too many changes to list, but all concerns raised in previous submission addressed.
>    - History: https://lore.kernel.org/platform-driver-x86/20240716051612.64842-1-luke@ljones.dev/
> - v3
>    - All concerns addressed.
>    - History: https://lore.kernel.org/platform-driver-x86/20240806020747.365042-1-luke@ljones.dev/
> - v4
>    - Use EXPORT_SYMBOL_NS_GPL() for the symbols required in this patch series
>    - Add patch for hid-asus due to the use of EXPORT_SYMBOL_NS_GPL()
>    - Split the PPT knobs out to a separate patch
>    - Split the hd_panel setting out to a new patch
>    - Clarify some of APU MEM configuration and convert int to hex
>    - Rename deprecated Kconfig option to ASUS_WMI_DEPRECATED_ATTRS
>    - Fixup cyclic dependency in Kconfig
> - v5
>    - deprecate patch: cleanup ``#if`, ``#endif` statements, edit kconfig detail, edit commit msg
>    - cleanup ppt* tuning patch
>    - proper error handling in module init, plus pr_err()
>    - ppt tunables have a notice if there is no match to get defaults
>    - better error handling in cpu core handling
>      - don't continue if failure
>    - use the mutex to gate WMI writes
> - V6
>    - correctly cleanup/unwind if module init fails
> - V7
>    - Remove review tags where the code changed significantly
>    - Add auto_screen_brightness WMI attribute support
>    - Move PPT patch to end
>    - Add support min/max PPT values for 36 laptops (and two handhelds)
>    - reword commit for "asus-wmi: export symbols used for read/write WMI"
>    - asus-armoury: move existing tunings to asus-armoury
>      - Correction to license header
>      - Remove the (initial) mutex use (added for core count only in that patch)
>      - Clarify some doc comments (attr_int_store)
>      - Cleanup pr_warn in dgpu/egpu/mux functions
>      - Restructure logic in asus_fw_attr_add()
>      - Check gpu_mux_dev_id and mini_led_dev_id before remove attrs
>    - asus-armoury: add core count control:
>      - add mutex to prevent possible concurrent write to the core
>        count WMI due to separated bit/little attributes
>    - asus-armoury: add ppt_* and nv_* tuning knobs:
>      - Move to end of series
>      - Refactor to use a table of allowed min/max values to
>        ensure safe settings
>      - General code cleanup
>    - Ensure checkpatch.pl returns clean for all
> - V8
>    - asus-armoury: move existing tunings to asus-armoury module
>      - Further cleanup: https://lore.kernel.org/platform-driver-x86/20250316230724.100165-2-luke@ljones.dev/T/#m72e203f64a5a28c9c21672406b2e9f554a8a8e38
>    - asus-armoury: add ppt_* and nv_* tuning knobs
>      - Address concerns in https://lore.kernel.org/platform-driver-x86/20250316230724.100165-2-luke@ljones.dev/T/#m77971b5c1e7f018954c16354e623fc06522c5e41
>      - Refactor struct asus_armoury_priv to record both AC and DC settings
>      - Tidy macros and functions affected by the above to be clearer as a result
>      - Move repeated strings such as "ppt_pl1_spl" to #defines
>      - Split should_create_tunable_attr() in to two functions to better clarify:
>        - is_power_tunable_attr()
>        - has_valid_limit()
>      - Restructure init_rog_tunables() to initialise AC and DC in a
>        way that makes more sense.
>      - Ensure that if DC setting table is not available then attributes
>        return -ENODEV only if on DC mode.
> - V9
>    - asus-armoury: move existing tunings to asus-armoury module
>      - return -EBUSY when eGPU/dGPU cannot be deactivated
>    - asus-armoury: add apu-mem control support
>      - discard the WMI presence bit fixing the functionality
>    - asus-armoury: add core count control
>      - replace mutex lock/unlock with guard
>      - move core count alloc for initialization in init_max_cpu_cores()
> - v10
>    - platform/x86: asus-wmi: export symbols used for read/write WMI
>      - fix error with redefinition of asus_wmi_set_devstate
>    - asus-armoury: move existing tunings to asus-armoury module
>      - hwmon or other -> hwmon or others
>      - fix wrong function name in documentation (attr_uint_store)
>      - use kstrtouint where appropriate
>      - (*) fix unreachable code warning: the fix turned out to be partial
>      - improve return values in case of error in egpu_enable_current_value_store
>    - asus-armoury: asus-armoury: add screen auto-brightness toggle
>      - actually register screen_auto_brightness attribute
> - v11
>    - cover-letter:
>      - reorganize the changelog of v10
>    - asus-armoury: move existing tunings to asus-armoury module
>      - move the DMIs list in its own include, fixing (*) for good
>    - asus-armoury: add ppt_* and nv_* tuning knobs
>      - fix warning about redefinition of ppt_pl2_sppt_def for GV601R
> - v12
>    - asus-armoury: add ppt_* and nv_* tuning knobs
>      - add min/max values for FA608WI and FX507VI
> - v13
>    - asus-armoury: add ppt_* and nv_* tuning knobs
>      - fix a typo in a comment about _def attributes
>      - add min/max values for GU605CW and G713PV
>    - asus-armoury: add apu-mem control support
>      - fix a possible out-of-bounds read in apu_mem_current_value_store
> - v14
>    - platform/x86: asus-wmi: rename ASUS_WMI_DEVID_PPT_FPPT
>      - added patch to rename the symbol for consistency
>    - platform/x86: asus-armoury: add ppt_* and nv_* tuning knobs
>      - remove the unchecked usage of dmi_get_system_info while
>        also increasing consistency with other messages
> 
> Denis Benato (1):
>    platform/x86: asus-wmi: rename ASUS_WMI_DEVID_PPT_FPPT
> 
> Luke D. Jones (8):
>    platform/x86: asus-wmi: export symbols used for read/write WMI
>    platform/x86: asus-armoury: move existing tunings to asus-armoury
>      module
>    platform/x86: asus-armoury: add panel_hd_mode attribute
>    platform/x86: asus-armoury: add apu-mem control support
>    platform/x86: asus-armoury: add core count control
>    platform/x86: asus-armoury: add screen auto-brightness toggle
>    platform/x86: asus-wmi: deprecate bios features
>    platform/x86: asus-armoury: add ppt_* and nv_* tuning knobs
> 
>   .../ABI/testing/sysfs-platform-asus-wmi       |   17 +
>   drivers/hid/hid-asus.c                        |    1 +
>   drivers/platform/x86/Kconfig                  |   23 +
>   drivers/platform/x86/Makefile                 |    1 +
>   drivers/platform/x86/asus-armoury.c           | 1172 ++++++++++++++
>   drivers/platform/x86/asus-armoury.h           | 1402 +++++++++++++++++
>   drivers/platform/x86/asus-wmi.c               |  170 +-
>   .../platform_data/x86/asus-wmi-leds-ids.h     |   50 +
>   include/linux/platform_data/x86/asus-wmi.h    |   62 +-
>   9 files changed, 2823 insertions(+), 75 deletions(-)
>   create mode 100644 drivers/platform/x86/asus-armoury.c
>   create mode 100644 drivers/platform/x86/asus-armoury.h
>   create mode 100644 include/linux/platform_data/x86/asus-wmi-leds-ids.h
> 

Powered by blists - more mailing lists