linux-kernel - Re: [PATCH v3 00/22] smb: fix some bugs, move duplicate definitions to common header file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKYAXd9GtfRDe50P2PGPOuy3LEnf5hMVAAfeKXYHN_+XY37ZVA@mail.gmail.com>
Date: Wed, 15 Oct 2025 14:43:56 +0900
From: Namjae Jeon <linkinjeon@...nel.org>
To: chenxiaosong.chenxiaosong@...ux.dev
Cc: stfrench@...rosoft.com, metze@...ba.org, pali@...nel.org, 
	smfrench@...il.com, sfrench@...ba.org, senozhatsky@...omium.org, 
	tom@...pey.com, pc@...guebit.org, ronniesahlberg@...il.com, 
	sprasad@...rosoft.com, bharathsm@...rosoft.com, christophe.jaillet@...adoo.fr, 
	zhangguodong@...inos.cn, linux-cifs@...r.kernel.org, 
	linux-kernel@...r.kernel.org, ChenXiaoSong <chenxiaosong@...inos.cn>
Subject: Re: [PATCH v3 00/22] smb: fix some bugs, move duplicate definitions
 to common header file

On Tue, Oct 14, 2025 at 4:20 PM <chenxiaosong.chenxiaosong@...ux.dev> wrote:
>
> From: ChenXiaoSong <chenxiaosong@...inos.cn>
>
> Emails from previous address were often not received (went to the spam
> folder or other reasons), and the cover letter wasn't linked to the
> patches. So yesterday I requested chenxiaosong.chenxiaosong@...ux.dev
> account and have now sent v3.
>
> Fix some bugs of smb server.
>
> In order to maintain the code more easily, move some duplicate definitions
> to common header file.
>
> Add some MS documentation references for macro and struct definitions.
I have applied 0001, 0002 patches to #ksmbd-for-next-next as they are
obvious bug fixes.
I will give you feedback on the remaining patches soon.
Thanks.
>
> v2->v3:
>   - Update patch #06: use "Suggested-by:" instead of "Reviewed-by:"
>
> v1->v2:
>   - Update patch #06 according to Christophe JAILLET's suggestions: https://lore.kernel.org/all/d03c64d2-46c0-42d8-8f88-28669e921c95@wanadoo.fr/
>
> v2:
>   - cover-letter: https://lore.kernel.org/all/40F04A8E2145E761+20251012161749.2994033-1-chenxiaosong@chenxiaosong.com/
>   - patches: https://lore.kernel.org/all/47508024F79AE36C+20251012161749.2994033-2-chenxiaosong@chenxiaosong.com/
>
> v1:
>   - cover-letter: https://lore.kernel.org/all/76A15C078023E21F+20251012150915.2992220-1-chenxiaosong@chenxiaosong.com/
>   - patches: https://lore.kernel.org/all/029014EF18C9D322+20251012150915.2992220-2-chenxiaosong@chenxiaosong.com/
>   - RESEND cover-letter: https://lore.kernel.org/all/37DF3D711BAD3621+20251012152247.2992573-1-chenxiaosong@chenxiaosong.com/
>   - RESEND patches: https://lore.kernel.org/all/9836A3F274B62345+20251012152247.2992573-2-chenxiaosong@chenxiaosong.com/
>
> ZhangGuoDong (10):
>   smb/server: fix possible memory leak in smb2_read()
>   smb/server: fix possible refcount leak in smb2_sess_setup()
>   smb: move some duplicate definitions to common/cifsglob.h
>   smb: move smb_version_values to common/cifsglob.h
>   smb: move get_rfc1002_len() to common/cifsglob.h
>   smb: move SMB1_PROTO_NUMBER to common/cifsglob.h
>   smb: move some duplicate definitions to common/smb2pdu.h
>   smb: move smb_sockaddr_in and smb_sockaddr_in6 to common/smb2pdu.h
>   smb: move copychunk definitions to common/smb2pdu.h
>   smb: move resume_key_ioctl_rsp to common/smb2pdu.h
>
> ChenXiaoSong (12):
>   smb: move smb2_file_network_open_info to common/smb2pdu.h
>   smb: move some duplicate definitions to common/cifspdu.h
>   smb: move file access permission bits definitions to common/cifspdu.h
>   smb: move SMB frame definitions to common/cifspdu.h
>   smb: move FILE_SYSTEM_ATTRIBUTE_INFO to common/cifspdu.h
>   smb: move FILE_SYSTEM_DEVICE_INFO to common/cifspdu.h
>   smb: move FILE_SYSTEM_INFO to common/cifspdu.h
>   smb: move FILE_DIRECTORY_INFO to common/cifspdu.h
>   smb: move FILE_FULL_DIRECTORY_INFO to common/cifspdu.h
>   smb: move FILE_BOTH_DIRECTORY_INFO to common/cifspdu.h
>   smb: move SEARCH_ID_FULL_DIR_INFO to common/cifspdu.h
>   smb: move FILE_SYSTEM_POSIX_INFO to common/cifspdu.h
>
>  fs/smb/client/cifsacl.c       |   4 +-
>  fs/smb/client/cifsglob.h      |  47 +---
>  fs/smb/client/cifspdu.h       | 436 +-------------------------------
>  fs/smb/client/cifssmb.c       |  10 +-
>  fs/smb/client/cifstransport.c |   8 +-
>  fs/smb/client/connect.c       |   2 +-
>  fs/smb/client/misc.c          |   2 +-
>  fs/smb/client/smb2ops.c       |  18 +-
>  fs/smb/client/smb2pdu.h       |  80 +-----
>  fs/smb/common/cifsglob.h      |  68 +++++
>  fs/smb/common/cifspdu.h       | 464 ++++++++++++++++++++++++++++++++++
>  fs/smb/common/smb2pdu.h       |  98 ++++++-
>  fs/smb/server/smb2misc.c      |   2 +-
>  fs/smb/server/smb2ops.c       |  32 +--
>  fs/smb/server/smb2pdu.c       | 114 +++++----
>  fs/smb/server/smb2pdu.h       |  67 -----
>  fs/smb/server/smb_common.c    |  10 +-
>  fs/smb/server/smb_common.h    | 304 +---------------------
>  fs/smb/server/smbacl.c        |   2 +-
>  fs/smb/server/vfs.c           |   2 +-
>  20 files changed, 735 insertions(+), 1035 deletions(-)
>  create mode 100644 fs/smb/common/cifsglob.h
>  create mode 100644 fs/smb/common/cifspdu.h
>
> --
> 2.43.0
>