linux-kernel - Re: [PATCH v2 3/3] misc: fastrpc: Update dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <4dcbf05b-1da6-417e-8d37-2756762fed94@app.fastmail.com>
Date: Wed, 15 Oct 2025 09:06:37 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: "Kumari Pallavi" <kumari.pallavi@....qualcomm.com>,
 kpallavi@....qualcomm.com, "Srinivas Kandagatla" <srini@...nel.org>,
 "Amol Maheshwari" <amahesh@....qualcomm.com>,
 "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>
Cc: quic_bkumar@...cinc.com, ekansh.gupta@....qualcomm.com,
 linux-kernel@...r.kernel.org, quic_chennak@...cinc.com,
 dri-devel@...ts.freedesktop.org, linux-arm-msm@...r.kernel.org,
 "Jingyi Wang" <jingyi.wang@....qualcomm.com>, aiqun.yu@....qualcomm.com,
 ktadakam@....qualcomm.com
Subject: Re: [PATCH v2 3/3] misc: fastrpc: Update dma_mask for CDSP support on
 Kaanapali SoC

On Wed, Oct 15, 2025, at 06:57, Kumari Pallavi wrote:
> diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c
> index 1a5d620b23f2..f2e5e53e9067 100644
> --- a/drivers/misc/fastrpc.c
> +++ b/drivers/misc/fastrpc.c
> @@ -267,6 +267,7 @@ struct fastrpc_session_ctx {
> 
>  struct fastrpc_soc_data {
>  	u32 sid_pos;
> +	u32 cdsp_dma_mask;
>  };

I see that you add the field here, but it is not initialized
anywhere. Did the initialization get lost in a rebase?

Also, this is not the mask but the address width,
so maybe rename it to cdsp_dma_bits?

       Arnd