linux-kernel - Re: [PATCH v6 0/7] Fix stale IOTLB entries for kernel address space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20251014174339.c7b7d2cfb9f60d225e4fe5ec@linux-foundation.org>
Date: Tue, 14 Oct 2025 17:43:39 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Lu Baolu <baolu.lu@...ux.intel.com>
Cc: Joerg Roedel <joro@...tes.org>, Will Deacon <will@...nel.org>, Robin
 Murphy <robin.murphy@....com>, Kevin Tian <kevin.tian@...el.com>, Jason
 Gunthorpe <jgg@...dia.com>, Jann Horn <jannh@...gle.com>, Vasant Hegde
 <vasant.hegde@....com>, Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar
 <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>, Dave Hansen
 <dave.hansen@...el.com>, Alistair Popple <apopple@...dia.com>, Peter
 Zijlstra <peterz@...radead.org>, Uladzislau Rezki <urezki@...il.com>,
 Jean-Philippe Brucker <jean-philippe@...aro.org>, Andy Lutomirski
 <luto@...nel.org>, Yi Lai <yi1.lai@...el.com>, David Hildenbrand
 <david@...hat.com>, Lorenzo Stoakes <lorenzo.stoakes@...cle.com>,
 "Liam R . Howlett" <Liam.Howlett@...cle.com>, Vlastimil Babka
 <vbabka@...e.cz>, Mike Rapoport <rppt@...nel.org>, Michal Hocko
 <mhocko@...nel.org>, Matthew Wilcox <willy@...radead.org>,
 iommu@...ts.linux.dev, security@...nel.org, x86@...nel.org,
 linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 0/7] Fix stale IOTLB entries for kernel address space

On Tue, 14 Oct 2025 21:04:30 +0800 Lu Baolu <baolu.lu@...ux.intel.com> wrote:

> This proposes a fix for a security vulnerability related to IOMMU Shared
> Virtual Addressing (SVA). In an SVA context, an IOMMU can cache kernel
> page table entries. When a kernel page table page is freed and
> reallocated for another purpose, the IOMMU might still hold stale,
> incorrect entries. This can be exploited to cause a use-after-free or
> write-after-free condition, potentially leading to privilege escalation
> or data corruption.

Is only x86 affected?

> This solution introduces a deferred freeing mechanism for kernel page
> table pages, which provides a safe window to notify the IOMMU to
> invalidate its caches before the page is reused.

Thanks for working on this.

Can we expect any performance impact from this?  Have any measurements
been performed?

Only [7/7] has a cc:stable, even though that patch is not at all
backportable.  Please give some thought and suggestions regarding
whether you think we should backport this into earlier kernels.

If "yes" then the size and scope of the series looks problematic.  Is
it possible to put together something simple and expedient just to plug
the hole in older kernels?

>  arch/x86/Kconfig              |  1 +
>  mm/Kconfig                    |  3 ++
>  include/asm-generic/pgalloc.h | 18 +++++++++
>  include/linux/iommu.h         |  4 ++
>  include/linux/mm.h            | 71 ++++++++++++++++++++++++++++++++---
>  arch/x86/mm/init_64.c         |  2 +-
>  arch/x86/mm/pat/set_memory.c  |  2 +-
>  arch/x86/mm/pgtable.c         | 12 +++---
>  drivers/iommu/iommu-sva.c     | 29 +++++++++++++-
>  mm/pgtable-generic.c          | 39 +++++++++++++++++++
>  10 files changed, 167 insertions(+), 14 deletions(-)

It isn't obvious which tree should carry this.  Were you thinking the
x86 tree?