linux-kernel - Re: [PATCH] platform/x86: huawei-wmi: add keys for HONOR models

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f609dd82-2cd5-cef4-746b-10dfd59380fc@linux.intel.com>
Date: Wed, 15 Oct 2025 11:30:44 +0300 (EEST)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: ston <ston.jia@...look.com>
cc: Hans de Goede <hansg@...nel.org>, platform-driver-x86@...r.kernel.org, 
    LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] platform/x86: huawei-wmi: add keys for HONOR models

On Tue, 14 Oct 2025, ston wrote:

> HONOR MagicBook X16/X14 models-

That dash seems misplaced in middle of a sentence.

> produced in 2025 cannot use the print key properly.
>   (input input25: Unknown key pressed, code: 0x028b)
> 
> This patch fixes this function.

Please use more precise wording and avoid starting with "This patch" (or 
similar phrases such as "This change").

> 
> Signed-off-by: ston <ston.jia@...look.com>

Please use full name in sign off.

> ---
>  drivers/platform/x86/huawei-wmi.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/platform/x86/huawei-wmi.c b/drivers/platform/x86/huawei-wmi.c
> index c3772df34..d3b7b673d 100644
> --- a/drivers/platform/x86/huawei-wmi.c
> +++ b/drivers/platform/x86/huawei-wmi.c
> @@ -81,6 +81,9 @@ static const struct key_entry huawei_wmi_keymap[] = {
>         { KE_KEY,    0x289, { KEY_WLAN } },
>         // Huawei |M| key
>         { KE_KEY,    0x28a, { KEY_CONFIG } },
> +       // HONOR keys
> +       { KE_KEY,    0x28b, { KEY_NOTIFICATION_CENTER } },
> +       { KE_KEY,    0x28e, { KEY_PRINT } },

You only mentioned single key in the changelog but are adding two here?
Please amend the changelog to cover the changes fully.

>         // Keyboard backlit
>         { KE_IGNORE, 0x293, { KEY_KBDILLUMTOGGLE } },
>         { KE_IGNORE, 0x294, { KEY_KBDILLUMUP } },
> 

-- 
 i.