lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <aO9jJ-wGR5ANmKZs@kernel.org>
Date: Wed, 15 Oct 2025 12:02:31 +0300
From: Mike Rapoport <rppt@...nel.org>
To: David Hildenbrand <david@...hat.com>
Cc: Itamar Dalal <dalalitamar@...il.com>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>,
	"linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"lorenzo.stoakes@...cle.com" <lorenzo.stoakes@...cle.com>,
	"riel@...riel.com" <riel@...riel.com>,
	"Liam.Howlett@...cle.com" <Liam.Howlett@...cle.com>,
	"vbabka@...e.cz" <vbabka@...e.cz>,
	"harry.yoo@...cle.com" <harry.yoo@...cle.com>,
	"jannh@...gle.com" <jannh@...gle.com>,
	"surenb@...gle.com" <surenb@...gle.com>,
	"mhocko@...e.com" <mhocko@...e.com>,
	"shuah@...nel.org" <shuah@...nel.org>
Subject: Re: selftests/mm/rmap: verify correct RMAP handling of COW pages
 after fork()

On Wed, Oct 15, 2025 at 10:49:48AM +0200, David Hildenbrand wrote:
> On 15.10.25 10:43, Itamar Dalal wrote:
> > Add a new test `migrate.cow_after_fork` that verifies correct RMAP handling
> > of Copy-On-Write (COW) pages after fork().
> > 
> > Before a write, the parent and child share the same PFN. After a write, the
> > child’s PFN differs. This confirms that proper COW duplication occurred and
> > that RMAP correctly tracks page ownership transitions during COW events.
> > 
> > Signed-off-by: Itamar-Dalal <dalalitamar@...il.com>
> > ---
> 
> Se my reply to your other patch.
> 
> For the next time
> 
> a) Use git-format-patch that will automatically add [PATCH]
> 
> b) Use versioning, e.g., [PATCH v1], explain changes since the last version
> under the "---" the
> 
> c) Use RESEND for resends, e.g., [PATCH v1 RESEND]
> 
> d) Use git-send-email to send mails out
> 
> The b4 tool might help as well.

And

e) please don't respin new version as soon as you get a single feedback.

https://docs.kernel.org/process/submitting-patches.html#don-t-get-discouraged-or-impatient
 

-- 
Sincerely yours,
Mike.

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ