linux-kernel - Re: [PATCH] power: supply: use ktime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251015115729.64eglmp262u7g3so@lcpd911>
Date: Wed, 15 Oct 2025 17:27:29 +0530
From: Dhruva Gole <d-gole@...com>
To: Michal Kubecek <mkubecek@...e.cz>
CC: Sebastian Reichel <sre@...nel.org>, <linux-pm@...r.kernel.org>,
        Hans de
 Goede <hansg@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] power: supply: use ktime_divns() to avoid 64-bit division

On Oct 15, 2025 at 09:56:31 +0200, Michal Kubecek wrote:
> The build of intel_dc_ti_battery module on i386 (32-bit) fails with
> 
> ERROR: modpost: "__udivdi3" [drivers/power/supply/intel_dc_ti_battery.ko]
> 
> This is caused by 64-bit division of ktime values by NSEC_PER_USEC. Use
> ktime_divns() helper which handles the division correctly on 32-bit
> architectures.
> 
> Fixes: 8c5795fe5527 ("power: supply: Add new Intel Dollar Cove TI battery driver")
> Signed-off-by: Michal Kubecek <mkubecek@...e.cz>
> ---

Good catch!
Reviewed-by: Dhruva Gole <d-gole@...com>

-- 
Best regards,
Dhruva Gole
Texas Instruments Incorporated