linux-kernel - Re: [PATCH v2 03/10] net: Convert proto_ops bind() callbacks to use sockaddr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aO-QV3kSxaYMaZqc@horms.kernel.org>
Date: Wed, 15 Oct 2025 13:15:19 +0100
From: Simon Horman <horms@...nel.org>
To: Kees Cook <kees@...nel.org>
Cc: Jakub Kicinski <kuba@...nel.org>,
	"Gustavo A. R. Silva" <gustavo@...eddedor.com>,
	Alexei Starovoitov <ast@...nel.org>,
	Daniel Borkmann <daniel@...earbox.net>,
	John Fastabend <john.fastabend@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	Kuniyuki Iwashima <kuniyu@...gle.com>,
	Willem de Bruijn <willemb@...gle.com>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, bpf@...r.kernel.org,
	linux-hardening@...r.kernel.org
Subject: Re: [PATCH v2 03/10] net: Convert proto_ops bind() callbacks to use
 sockaddr_unspec

On Tue, Oct 14, 2025 at 03:43:25PM -0700, Kees Cook wrote:
> Update all struct proto_ops bind() callback function prototypes from
> "struct sockaddr *" to "struct sockaddr_unspec *" to avoid lying to the
> compiler about object sizes. Calls into struct proto handlers gain casts
> that will be removed in the struct proto conversion patch.
> 
> No binary changes expected.
> 
> Signed-off-by: Kees Cook <kees@...nel.org>

...

> diff --git a/net/mctp/af_mctp.c b/net/mctp/af_mctp.c
> index b99ba14f39d2..0a795901e4f2 100644
> --- a/net/mctp/af_mctp.c
> +++ b/net/mctp/af_mctp.c
> @@ -49,7 +49,7 @@ static bool mctp_sockaddr_ext_is_ok(const struct sockaddr_mctp_ext *addr)
>  	       !addr->__smctp_pad0[2];
>  }
>  
> -static int mctp_bind(struct socket *sock, struct sockaddr *addr, int addrlen)
> +static int mctp_bind(struct socket *sock, struct sockaddr_unspec *addr, int addrlen)
>  {
>  	struct sock *sk = sock->sk;
>  	struct mctp_sock *msk = container_of(sk, struct mctp_sock, sk);
> @@ -128,7 +128,7 @@ static int mctp_bind(struct socket *sock, struct sockaddr *addr, int addrlen)
>  /* Used to set a specific peer prior to bind. Not used for outbound
>   * connections (Tag Owner set) since MCTP is a datagram protocol.
>   */
> -static int mctp_connect(struct socket *sock, struct sockaddr *addr,
> +static int mctp_connect(struct socket *sock, struct sockaddr_unspec *addr,
>  			int addrlen, int flags)
>  {
>  	struct sock *sk = sock->sk;

Hi Kees,

The change to mctp_connect() results GCC 15.2.0 warning as follows:

net/mctp/af_mctp.c:632:27: error: initialization of 'int (*)(struct socket *, struct sockaddr *, int,  int)' from incompatible pointer type 'int (*)(struct socket *, struct sockaddr_unspec *, int,  int)' [-Wincompatible-pointer-types]
  632 |         .connect        = mctp_connect,
      |                           ^~~~~~~~~~~~

As I don't see other _connect functions updated in this patch,
perhaps it is out of place here and should be dropped from this patch.

...

-- 
pw-bot: cr