linux-kernel - Re: [PATCH v2 1/2] drivers/base/node: Fold register_node() into register_one

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ed99ffc0-4a70-416d-9bf3-58c4a3ebe566@redhat.com>
Date: Wed, 15 Oct 2025 14:36:28 +0200
From: David Hildenbrand <david@...hat.com>
To: Donet Tom <donettom@...ux.ibm.com>,
 Andrew Morton <akpm@...ux-foundation.org>, Mike Rapoport <rppt@...nel.org>,
 Oscar Salvador <osalvador@...e.de>
Cc: Ritesh Harjani <ritesh.list@...il.com>,
 Aboorva Devarajan <aboorvad@...ux.ibm.com>, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org, Madhavan Srinivasan <maddy@...ux.ibm.com>,
 linuxppc-dev@...ts.ozlabs.org, Christophe Leroy
 <christophe.leroy@...roup.eu>, Peter Zijlstra <peterz@...radead.org>,
 Ingo Molnar <mingo@...hat.com>, x86@...nel.org,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>, rafael@...nel.org,
 Danilo Krummrich <dakr@...nel.org>, Dave Jiang <dave.jiang@...el.com>
Subject: Re: [PATCH v2 1/2] drivers/base/node: Fold register_node() into
 register_one_node()

On 14.10.25 17:39, Donet Tom wrote:
> The function register_node() is only called from register_one_node().
> This patch folds register_node() into its only caller and renames
> register_one_node() to register_node().
> 
> This reduces unnecessary indirection and simplifies the code structure.
> No functional changes are introduced.
> 
> Acked-by: Mike Rapoport (Microsoft) <rppt@...nel.org>
> Signed-off-by: Donet Tom <donettom@...ux.ibm.com>
> ---
[...]

>   /**
>    * unregister_node - unregister a node device
>    * @node: node going away
> @@ -907,7 +880,13 @@ void register_memory_blocks_under_node_hotplug(int nid, unsigned long start_pfn,
>   }
>   #endif /* CONFIG_MEMORY_HOTPLUG */
>   
> -int register_one_node(int nid)
> +/**
> + * register_node - Initialize and register the node device.
> + * @nid - Node number to use when creating the device.
>

I assume that should be "@nid: ..." to silence the warning.

Acked-by: David Hildenbrand <david@...hat.com>

-- 
Cheers

David / dhildenb