linux-kernel - Re: [net-next PATCH] net: phy: as21xxx: fill in inband caps and better handle inband

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aPEOBRytURg6vKqN@shell.armlinux.org.uk>
Date: Thu, 16 Oct 2025 16:23:49 +0100
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: Christian Marangi <ansuelsmth@...il.com>
Cc: Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	Frank Wunderlich <frank-w@...lic-files.de>
Subject: Re: [net-next PATCH] net: phy: as21xxx: fill in inband caps and
 better handle inband

On Thu, Oct 16, 2025 at 05:20:07PM +0200, Christian Marangi wrote:
> +static int as21xxx_config_inband(struct phy_device *phydev,
> +				 unsigned int modes)
> +{
> +	if (modes == LINK_INBAND_ENABLE)
> +		return aeon_dpc_ra_enable(phydev);

So what happens when phylink requests inband to be disabled?

I really don't like implementations that enable something but then
provide no way to disable it.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!