linux-kernel - Re: [PATCH] sysfs: check visibility before changing group attribute ownership

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251016083835.096c09e1@kernel.org>
Date: Thu, 16 Oct 2025 08:38:35 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Fernando Fernandez Mancera <fmancera@...e.de>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 gregkh@...uxfoundation.org, cynthia@...mx.dev, rafael@...nel.org,
 dakr@...nel.org, christian.brauner@...ntu.com, edumazet@...gle.com,
 pabeni@...hat.com, davem@...emloft.net, horms@...nel.org
Subject: Re: [PATCH] sysfs: check visibility before changing group attribute
 ownership

On Thu, 16 Oct 2025 12:14:56 +0200 Fernando Fernandez Mancera wrote:
> Since commit 0c17270f9b92 ("net: sysfs: Implement is_visible for
> phys_(port_id, port_name, switch_id)"), __dev_change_net_namespace() can
> hit WARN_ON() when trying to change owner of a file that isn't visible.
> See the trace below:

Dunno much about sysfs but this is what I had in mind so FWIW:

Reviewed-by: Jakub Kicinski <kuba@...nel.org>

I'd be tempted to chuck:

Fixes: 0c17270f9b92 ("net: sysfs: Implement is_visible for phys_(port_id, port_name, switch_id)")

here as well. Or are we certain there are other callers that could have
triggered this earlier?

> Reported-by: Cynthia <cynthia@...mx.dev>

Perhaps:

Reported-and-bisected-by: ...