linux-kernel - Re: [RFC PATCH 2/2] checkpatch: cosmetic-style tweak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1b3a9a196ddf4127e5148e33d3df7f70ae77a080.camel@perches.com>
Date: Thu, 16 Oct 2025 08:54:37 -0700
From: Joe Perches <joe@...ches.com>
To: Jim Cromie <jim.cromie@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 2/2] checkpatch: cosmetic-style tweak

On Wed, 2025-10-15 at 11:51 -0600, Jim Cromie wrote:
> no functional change, slightly narrower on-screen, maybe clearer ?
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -4019,11 +4019,13 @@ sub process {
>  				if ($newindent ne $goodtabindent &&
>  				    $newindent ne $goodspaceindent) {
>  
> -					if (CHK("PARENTHESIS_ALIGNMENT",
> -						"Alignment should match open parenthesis\n" . $hereprev) &&
> -					    $fix && $line =~ /^\+/) {
> +					CHK("PARENTHESIS_ALIGNMENT",
> +					    "Alignment should match open parenthesis\n" . $hereprev)
> +					and do {
> +					    if ($fix && $line =~ /^\+/) {
>  						$fixed[$fixlinenr] =~
>  						    s/^\+[ \t]*/\+$goodtabindent/;
> +					    }

nack.

"and do" is not used anywhere by checkpatch
and I don't want to introduce it.