[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <aPEhiVdgkVLvF9Et@makrotopia.org>
Date: Thu, 16 Oct 2025 17:47:05 +0100
From: Daniel Golle <daniel@...rotopia.org>
To: Sjoerd Simons <sjoerd@...labora.com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Matthias Brugger <matthias.bgg@...il.com>,
AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
Ryder Lee <ryder.lee@...iatek.com>,
Jianjun Wang <jianjun.wang@...iatek.com>,
Bjorn Helgaas <bhelgaas@...gle.com>,
Lorenzo Pieralisi <lpieralisi@...nel.org>,
Krzysztof WilczyĆski <kwilczynski@...nel.org>,
Manivannan Sadhasivam <mani@...nel.org>,
Chunfeng Yun <chunfeng.yun@...iatek.com>,
Vinod Koul <vkoul@...nel.org>,
Kishon Vijay Abraham I <kishon@...nel.org>,
Lee Jones <lee@...nel.org>, Andrew Lunn <andrew+netdev@...n.ch>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Lorenzo Bianconi <lorenzo@...nel.org>, Felix Fietkau <nbd@....name>,
kernel@...labora.com, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org, linux-pci@...r.kernel.org,
linux-phy@...ts.infradead.org, netdev@...r.kernel.org,
Bryan Hinton <bryan@...anhinton.com>
Subject: Re: [PATCH 10/15] arm64: dts: mediatek: mt7981b: Add Ethernet and
WiFi offload support
On Thu, Oct 16, 2025 at 12:08:46PM +0200, Sjoerd Simons wrote:
> Add device tree nodes for the Ethernet subsystem on MT7981B SoC,
> including:
> - Ethernet MAC controller with dual GMAC support
> - Wireless Ethernet Dispatch (WED)
> - SGMII PHY controllers for high-speed Ethernet interfaces
> - Reserved memory regions for WiFi offload processor
>
> Signed-off-by: Sjoerd Simons <sjoerd@...labora.com>
> ---
> arch/arm64/boot/dts/mediatek/mt7981b.dtsi | 133 ++++++++++++++++++++++++++++++
> 1 file changed, 133 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt7981b.dtsi b/arch/arm64/boot/dts/mediatek/mt7981b.dtsi
> index 13950fe6e8766..c85fa0ddf2da8 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7981b.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt7981b.dtsi
> @@ -2,6 +2,7 @@
>
> #include <dt-bindings/clock/mediatek,mt7981-clk.h>
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> +#include <dt-bindings/leds/common.h>
> #include <dt-bindings/phy/phy.h>
> #include <dt-bindings/reset/mt7986-resets.h>
>
> @@ -47,11 +48,36 @@ reserved-memory {
> #size-cells = <2>;
> ranges;
>
> + wo_boot: wo-boot@...94000 {
> + reg = <0 0x15194000 0 0x1000>;
> + no-map;
> + };
> +
> + wo_ilm0: wo-ilm@...e0000 {
> + reg = <0 0x151e0000 0 0x8000>;
> + no-map;
> + };
> +
> + wo_dlm0: wo-dlm@...e8000 {
> + reg = <0 0x151e8000 0 0x2000>;
> + no-map;
> + };
> +
> /* 192 KiB reserved for ARM Trusted Firmware (BL31) */
> secmon_reserved: secmon@...00000 {
> reg = <0 0x43000000 0 0x30000>;
> no-map;
> };
> +
> + wo_emi0: wo-emi@...80000 {
> + reg = <0 0x47d80000 0 0x40000>;
> + no-map;
> + };
> +
> + wo_data: wo-data@...c0000 {
> + reg = <0 0x47dc0000 0 0x240000>;
> + no-map;
> + };
> };
>
> soc {
> @@ -107,6 +133,18 @@ pwm: pwm@...48000 {
> #pwm-cells = <2>;
> };
>
> + sgmiisys0: syscon@...60000 {
> + compatible = "mediatek,mt7981-sgmiisys_0", "syscon";
> + reg = <0 0x10060000 0 0x1000>;
> + #clock-cells = <1>;
> + };
> +
> + sgmiisys1: syscon@...70000 {
> + compatible = "mediatek,mt7981-sgmiisys_1", "syscon";
> + reg = <0 0x10070000 0 0x1000>;
> + #clock-cells = <1>;
> + };
> +
> uart0: serial@...02000 {
> compatible = "mediatek,mt7981-uart", "mediatek,mt6577-uart";
> reg = <0 0x11002000 0 0x100>;
> @@ -338,6 +376,10 @@ soc-uuid@140 {
> thermal_calibration: thermal-calib@274 {
> reg = <0x274 0xc>;
> };
> +
> + phy_calibration: phy-calib@8dc {
> + reg = <0x8dc 0x10>;
> + };
> };
>
> ethsys: clock-controller@...00000 {
> @@ -347,6 +389,97 @@ ethsys: clock-controller@...00000 {
> #reset-cells = <1>;
> };
>
> + wed: wed@...10000 {
> + compatible = "mediatek,mt7981-wed",
> + "syscon";
> + reg = <0 0x15010000 0 0x1000>;
> + interrupt-parent = <&gic>;
> + interrupts = <GIC_SPI 205 IRQ_TYPE_LEVEL_HIGH>;
> + memory-region = <&wo_emi0>, <&wo_ilm0>, <&wo_dlm0>,
> + <&wo_data>, <&wo_boot>;
> + memory-region-names = "wo-emi", "wo-ilm", "wo-dlm",
> + "wo-data", "wo-boot";
> + mediatek,wo-ccif = <&wo_ccif0>;
> + };
> +
> + eth: ethernet@...00000 {
> + compatible = "mediatek,mt7981-eth";
> + reg = <0 0x15100000 0 0x40000>;
> + assigned-clocks = <&topckgen CLK_TOP_NETSYS_2X_SEL>,
> + <&topckgen CLK_TOP_SGM_325M_SEL>;
> + assigned-clock-parents = <&topckgen CLK_TOP_CB_NET2_800M>,
> + <&topckgen CLK_TOP_CB_SGM_325M>;
> + clocks = <ðsys CLK_ETH_FE_EN>,
> + <ðsys CLK_ETH_GP2_EN>,
> + <ðsys CLK_ETH_GP1_EN>,
> + <ðsys CLK_ETH_WOCPU0_EN>,
> + <&topckgen CLK_TOP_SGM_REG>,
> + <&sgmiisys0 CLK_SGM0_TX_EN>,
> + <&sgmiisys0 CLK_SGM0_RX_EN>,
> + <&sgmiisys0 CLK_SGM0_CK0_EN>,
> + <&sgmiisys0 CLK_SGM0_CDR_CK0_EN>,
> + <&sgmiisys1 CLK_SGM1_TX_EN>,
> + <&sgmiisys1 CLK_SGM1_RX_EN>,
> + <&sgmiisys1 CLK_SGM1_CK1_EN>,
> + <&sgmiisys1 CLK_SGM1_CDR_CK1_EN>,
> + <&topckgen CLK_TOP_NETSYS_SEL>,
> + <&topckgen CLK_TOP_NETSYS_500M_SEL>;
> + clock-names = "fe", "gp2", "gp1", "wocpu0",
> + "sgmii_ck",
> + "sgmii_tx250m", "sgmii_rx250m",
> + "sgmii_cdr_ref", "sgmii_cdr_fb",
> + "sgmii2_tx250m", "sgmii2_rx250m",
> + "sgmii2_cdr_ref", "sgmii2_cdr_fb",
> + "netsys0", "netsys1";
> + interrupts = <GIC_SPI 196 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 197 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 198 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 199 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 189 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 190 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 191 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 192 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "fe0", "fe1", "fe2", "fe3", "pdma0",
> + "pdma1", "pdma2", "pdma3";
> + sram = <ð_sram>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + mediatek,ethsys = <ðsys>;
> + mediatek,sgmiisys = <&sgmiisys0>, <&sgmiisys1>;
> + mediatek,infracfg = <&topmisc>;
> + mediatek,wed = <&wed>;
> + status = "disabled";
> +
> + mdio_bus: mdio-bus {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + int_gbe_phy: ethernet-phy@0 {
> + compatible = "ethernet-phy-ieee802.3-c22";
> + reg = <0>;
> + phy-mode = "gmii";
> + phy-is-integrated;
> + nvmem-cells = <&phy_calibration>;
> + nvmem-cell-names = "phy-cal-data";
Please also define the two LEDs here with their corresponding (only)
pinctrl options for each of them, with 'status = "disabled";'. This
makes it easier for boards to make use of the Ethernet PHY leds by just
referencing the LED and setting the status to 'okay'.
> + };
> + };
> + };
> +
> + eth_sram: sram@...40000 {
> + compatible = "mmio-sram";
> + reg = <0 0x15140000 0 0x40000>;
> + ranges = <0 0x15140000 0 0x40000>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + };
> +
> + wo_ccif0: syscon@...a5000 {
> + compatible = "mediatek,mt7986-wo-ccif", "syscon";
> + reg = <0 0x151a5000 0 0x1000>;
> + interrupt-parent = <&gic>;
> + interrupts = <GIC_SPI 211 IRQ_TYPE_LEVEL_HIGH>;
> + };
> +
> wifi: wifi@...00000 {
> compatible = "mediatek,mt7981-wmac";
> reg = <0 0x18000000 0 0x1000000>,
>
> --
> 2.51.0
>
Powered by blists - more mailing lists