linux-kernel - Re: [PATCH v2 bpf] bpf: Fix memory leak in __lookup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ab6554712b0f23b1a64154910f77ee47fc596c18.camel@gmail.com>
Date: Thu, 16 Oct 2025 10:38:54 -0700
From: Eduard Zingerman <eddyz87@...il.com>
To: Shardul Bankar <shardulsb08@...il.com>, bpf@...r.kernel.org
Cc: Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann
 <daniel@...earbox.net>,  Andrii Nakryiko <andrii@...nel.org>, Martin KaFai
 Lau <martin.lau@...ux.dev>, Song Liu <song@...nel.org>,  Yonghong Song
 <yonghong.song@...ux.dev>, John Fastabend <john.fastabend@...il.com>, KP
 Singh	 <kpsingh@...nel.org>, Stanislav Fomichev <sdf@...ichev.me>, Hao Luo	
 <haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>, open list	
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 bpf] bpf: Fix memory leak in __lookup_instance error
 path

On Thu, 2025-10-16 at 12:03 +0530, Shardul Bankar wrote:
> When __lookup_instance() allocates a func_instance structure but fails
> to allocate the must_write_set array, it returns an error without freeing
> the previously allocated func_instance. This causes a memory leak of 192
> bytes (sizeof(struct func_instance)) each time this error path is triggered.
> 
> Fix by freeing 'result' on must_write_set allocation failure.
> 
> Fixes: b3698c356ad9 ("bpf: callchain sensitive stack liveness tracking using CFG")
> Reported-by: BPF Runtime Fuzzer (BRF)
> Signed-off-by: Shardul Bankar <shardulsb08@...il.com>
> v2: Resend with complete CC list.
> ---

Thank you for the fix!

Acked-by: Eduard Zingerman <eddyz87@...il.com>

[...]