linux-kernel - Re: [PATCH v7 2/4] Add SPAcc ahash support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9ba77ca2-7b22-44da-beaf-dc66801252b5@web.de>
Date: Thu, 16 Oct 2025 20:15:27 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Bhoomika Kadabi <bhoomikak@...avyalabs.com>,
 Manjunath Hadli <manjunath.hadli@...avyalabs.com>,
 Pavitrakumar Managutte <pavitrakumarm@...avyalabs.com>,
 Ruud Derwig <Ruud.Derwig@...opsys.com>, linux-crypto@...r.kernel.org,
 devicetree@...r.kernel.org, Herbert Xu <herbert@...dor.apana.org.au>,
 Rob Herring <robh@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>,
 Aditya Kulkarni <adityak@...avyalabs.com>, Conor Dooley
 <conor+dt@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 T Pratham <t-pratham@...com>
Subject: Re: [PATCH v7 2/4] Add SPAcc ahash support

> Add ahash support to SPAcc driver.
…

Please choose a corresponding subsystem specification for the patch subject.


…
> +++ b/drivers/crypto/dwc-spacc/spacc_ahash.c
> @@ -0,0 +1,980 @@
…
> +static int spacc_register_hash(struct spacc_alg *salg)
> +{
…
> +	mutex_lock(&spacc_hash_alg_mutex);
> +	list_add(&salg->list, &spacc_hash_alg_list);
> +	mutex_unlock(&spacc_hash_alg_mutex);
> +
> +	return 0;
> +}
…

Under which circumstances would you become interested to apply a statement
like “guard(mutex)(&spacc_hash_alg_mutex);”?
https://elixir.bootlin.com/linux/v6.17.1/source/include/linux/mutex.h#L228

Regards,
Markus