linux-kernel - Re: [PATCH v2] nfsd: Use MD5 library instead of crypto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <176063936413.28537.4413010868699924082.b4-ty@oracle.com>
Date: Thu, 16 Oct 2025 14:31:46 -0400
From: Chuck Lever <cel@...nel.org>
To: linux-nfs@...r.kernel.org,
	Jeff Layton <jlayton@...nel.org>,
	Eric Biggers <ebiggers@...nel.org>
Cc: Chuck Lever <chuck.lever@...cle.com>,
	NeilBrown <neil@...wn.name>,
	Olga Kornievskaia <okorniev@...hat.com>,
	Dai Ngo <Dai.Ngo@...cle.com>,
	Tom Talpey <tom@...pey.com>,
	linux-crypto@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] nfsd: Use MD5 library instead of crypto_shash

From: Chuck Lever <chuck.lever@...cle.com>

On Thu, 16 Oct 2025 11:15:34 -0700, Eric Biggers wrote:
> Update NFSD's support for "legacy client tracking" (which uses MD5) to
> use the MD5 library instead of crypto_shash.  This has several benefits:
> 
> - Simpler code.  Notably, much of the error-handling code is no longer
>   needed, since the library functions can't fail.
> 
> - Improved performance due to reduced overhead.  A microbenchmark of
>   nfs4_make_rec_clidname() shows a speedup from 1455 cycles to 425.
> 
> [...]

Applied to nfsd-testing, thanks!

Note that the posted version of this patch does not apply cleanly to
the nfsd-testing branch here:

https://git.kernel.org/pub/scm/linux/kernel/git/cel/linux.git/log/?h=nfsd-testing

Be sure to rebase on that branch when posting subsequence patches
that target NFSD.

[1/1] nfsd: Use MD5 library instead of crypto_shash
      commit: 4a8d4b1d4b8abcc0d73b924d4d15828dd2ead301

--
Chuck Lever