linux-kernel - Re: [PATCH 8/8] ASoC: cs530x: Add DT compartible strings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b90e6b37-478e-42dd-9afd-4c6a44580228@kernel.org>
Date: Thu, 16 Oct 2025 07:42:42 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Vitaly Rodionov <vitalyr@...nsource.cirrus.com>,
 Mark Brown <broonie@...nel.org>
Cc: Liam Girdwood <lgirdwood@...il.com>, Takashi Iwai <tiwai@...e.com>,
 Jaroslav Kysela <perex@...ex.cz>, linux-sound@...r.kernel.org,
 linux-kernel@...r.kernel.org, patches@...nsource.cirrus.com
Subject: Re: [PATCH 8/8] ASoC: cs530x: Add DT compartible strings

On 15/10/2025 11:26, Vitaly Rodionov wrote:
> Signed-off-by: Vitaly Rodionov <vitalyr@...nsource.cirrus.com>
> ---
>  Documentation/devicetree/bindings/sound/cirrus,cs530x.yaml | 4 ++++

1.
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.

You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time.

Please kindly resend and include all necessary To/Cc entries.

2. Also, missing commit msg.

3. Please use subject prefixes matching the subsystem. You can get them
for example with `git log --oneline -- DIRECTORY_OR_FILE` on the
directory your patch is touching. For bindings, the preferred subjects
are explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters

4. Please organize the patch documenting compatible (DT bindings) before
their user.
See also:
https://elixir.bootlin.com/linux/v6.14-rc6/source/Documentation/devicetree/bindings/submitting-patches.rst#L46

>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/cirrus,cs530x.yaml b/Documentation/devicetree/bindings/sound/cirrus,cs530x.yaml
> index 9582eb8eb418..90a5cea0632d 100644
> --- a/Documentation/devicetree/bindings/sound/cirrus,cs530x.yaml
> +++ b/Documentation/devicetree/bindings/sound/cirrus,cs530x.yaml
> @@ -22,6 +22,10 @@ properties:
>        - cirrus,cs5302
>        - cirrus,cs5304
>        - cirrus,cs5308
> +      - cirrus,cs4282
> +      - cirrus,cs4302
> +      - cirrus,cs4304
> +      - cirrus,cs4308

Keep the order.

Best regards,
Krzysztof