linux-kernel - Re: [PATCH v2] nfsd: Use MD5 library instead of crypto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c62debc0-e2e8-45e2-8b07-8d8047044764@kernel.org>
Date: Thu, 16 Oct 2025 15:00:06 -0400
From: Chuck Lever <cel@...nel.org>
To: Eric Biggers <ebiggers@...nel.org>
Cc: linux-nfs@...r.kernel.org, Jeff Layton <jlayton@...nel.org>,
 Chuck Lever <chuck.lever@...cle.com>, NeilBrown <neil@...wn.name>,
 Olga Kornievskaia <okorniev@...hat.com>, Dai Ngo <Dai.Ngo@...cle.com>,
 Tom Talpey <tom@...pey.com>, linux-crypto@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] nfsd: Use MD5 library instead of crypto_shash

On 10/16/25 2:53 PM, Eric Biggers wrote:
> On Thu, Oct 16, 2025 at 02:31:46PM -0400, Chuck Lever wrote:
>> From: Chuck Lever <chuck.lever@...cle.com>
>>
>> On Thu, 16 Oct 2025 11:15:34 -0700, Eric Biggers wrote:
>>> Update NFSD's support for "legacy client tracking" (which uses MD5) to
>>> use the MD5 library instead of crypto_shash.  This has several benefits:
>>>
>>> - Simpler code.  Notably, much of the error-handling code is no longer
>>>   needed, since the library functions can't fail.
>>>
>>> - Improved performance due to reduced overhead.  A microbenchmark of
>>>   nfs4_make_rec_clidname() shows a speedup from 1455 cycles to 425.
>>>
>>> [...]
>>
>> Applied to nfsd-testing, thanks!
>>
>> Note that the posted version of this patch does not apply cleanly to
>> the nfsd-testing branch here:
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/cel/linux.git/log/?h=nfsd-testing
>>
>> Be sure to rebase on that branch when posting subsequence patches
>> that target NFSD.
> 
> Sorry, I had just based it on v6.18-rc1.  It did also apply cleanly to
> nfsd-testing f59a20b8390dd with either 'git am -3' or 'git cherry-pick'.
> 
> I noticed you changed the author to yourself when applying.  Could you
> fix that?

That was unintentional, due to applying the patch by hand. Fixed.


-- 
Chuck Lever