linux-kernel - Re: [PATCH v3 11/11] dt-bindings: sound: cirrus: cs530x: Add additional cs530x family variants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9226bc99-13a6-44af-937f-b85f8c26da2c@kernel.org>
Date: Thu, 16 Oct 2025 21:15:13 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Vitaly Rodionov <vitalyr@...nsource.cirrus.com>,
 Mark Brown <broonie@...nel.org>
Cc: Krzysztof Kozlowski <krzk+dt@...nel.org>, Takashi Iwai <tiwai@...e.com>,
 Jaroslav Kysela <perex@...ex.cz>, David Rhodes <david.rhodes@...rus.com>,
 Richard Fitzgerald <rf@...nsource.cirrus.com>,
 Liam Girdwood <lgirdwood@...il.com>, Rob Herring <robh@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, linux-sound@...r.kernel.org,
 linux-kernel@...r.kernel.org, patches@...nsource.cirrus.com,
 devicetree@...r.kernel.org
Subject: Re: [PATCH v3 11/11] dt-bindings: sound: cirrus: cs530x: Add
 additional cs530x family variants

On 16/10/2025 18:58, Vitaly Rodionov wrote:
> This patch adds additional cs530x family variants - DAC and CODEC parts.
> 
> Signed-off-by: Vitaly Rodionov <vitalyr@...nsource.cirrus.com>

No improvements in the subject. Please read carefully my comments again.

> ---
>  Documentation/devicetree/bindings/sound/cirrus,cs530x.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/cirrus,cs530x.yaml b/Documentation/devicetree/bindings/sound/cirrus,cs530x.yaml
> index 9582eb8eb418..90a5cea0632d 100644
> --- a/Documentation/devicetree/bindings/sound/cirrus,cs530x.yaml
> +++ b/Documentation/devicetree/bindings/sound/cirrus,cs530x.yaml
> @@ -22,6 +22,10 @@ properties:
>        - cirrus,cs5302
>        - cirrus,cs5304
>        - cirrus,cs5308
> +      - cirrus,cs4282
> +      - cirrus,cs4302
> +      - cirrus,cs4304
> +      - cirrus,cs4308
No improvements here, either.

Best regards,
Krzysztof