linux-kernel - Re: [PATCH 1/2] dt-bindings: sound: qcom,sm8250: add QRB2210 and RB1 soundcards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAO9ioeVcqT_Yhvz-RMCucLtcpa4xCLrA+srM8Vy_ZZ-650ZQnw@mail.gmail.com>
Date: Thu, 16 Oct 2025 22:46:47 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
To: Srinivas Kandagatla <srinivas.kandagatla@....qualcomm.com>
Cc: Alexey Klimov <alexey.klimov@...aro.org>,
        Srinivas Kandagatla <srini@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
        Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>, Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, linux-sound@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: sound: qcom,sm8250: add QRB2210 and RB1 soundcards

On Thu, 16 Oct 2025 at 18:08, Srinivas Kandagatla
<srinivas.kandagatla@....qualcomm.com> wrote:
>
>
>
> On 10/7/25 2:26 AM, Alexey Klimov wrote:
> > Add soundcard compatible for QRB2210 (QCM2290) platforms.
> > While at this, also add QRB2210 RB1 entry which is set to be
> > compatible with QRB2210 soundcard.
> >
> > Cc: Srinivas Kandagatla <srini@...nel.org>
> > Signed-off-by: Alexey Klimov <alexey.klimov@...aro.org>
> > ---
> >  Documentation/devicetree/bindings/sound/qcom,sm8250.yaml | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml
> > index 8ac91625dce5ccba5c5f31748c36296b12fac1a6..c29e59d0e8043fe2617b969be216525b493458c4 100644
> > --- a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml
> > +++ b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml
> > @@ -21,6 +21,10 @@ properties:
> >                - lenovo,yoga-c630-sndcard
> >                - qcom,db845c-sndcard
> >            - const: qcom,sdm845-sndcard
> > +      - items:
> > +          - enum:
> > +              - qcom,qrb2210-rb1-sndcard
> I don't think you need rb1 specific compatible here, unless there this
> is totally different to what the base compatible can provide.

Why do we need to deviate from other platforms which declare
board-specific compat too?

>
> --srini> +          - const: qcom,qrb2210-sndcard

Broken quoting

> >        - items:
> >            - enum:
> >                - qcom,sm8550-sndcard
> > @@ -37,6 +41,7 @@ properties:
> >            - qcom,qcs8275-sndcard
> >            - qcom,qcs9075-sndcard
> >            - qcom,qcs9100-sndcard
> > +          - qcom,qrb2210-sndcard
> >            - qcom,qrb4210-rb2-sndcard
> >            - qcom,qrb5165-rb5-sndcard
> >            - qcom,sc7180-qdsp6-sndcard
> >
>


-- 
With best wishes
Dmitry