linux-kernel - Re: [PATCH v3 7/8] arm64: dts: qcom: sdm845-oneplus: Describe TE gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e230521b-02f5-4219-a196-eaede1a31cf6@ixit.cz>
Date: Thu, 16 Oct 2025 23:00:05 +0200
From: David Heidelberg <david@...t.cz>
To: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
Cc: Neil Armstrong <neil.armstrong@...aro.org>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Thierry Reding
 <thierry.reding@...il.com>, Sam Ravnborg <sam@...nborg.org>,
 Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>,
 Casey Connolly <casey.connolly@...aro.org>,
 Jessica Zhang <jesszhan0024@...il.com>, dri-devel@...ts.freedesktop.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-msm@...r.kernel.org, phone-devel@...r.kernel.org,
 Konrad Dybcio <konrad.dybcio@....qualcomm.com>
Subject: Re: [PATCH v3 7/8] arm64: dts: qcom: sdm845-oneplus: Describe TE gpio

On 16/10/2025 22:15, Dmitry Baryshkov wrote:
> On Thu, Oct 16, 2025 at 06:17:02PM +0200, David Heidelberg via B4 Relay wrote:
>> From: David Heidelberg <david@...t.cz>
>>
>> Describe panel Tearing Effect (TE) GPIO line.
>>
>> Reviewed-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
>> Signed-off-by: David Heidelberg <david@...t.cz>
>> ---
>>   arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
>> index a8e87507d667b..b663345de0214 100644
>> --- a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
>> @@ -460,6 +460,7 @@ display_panel: panel@0 {
>>   		vci-supply = <&panel_vci_3v3>;
>>   		poc-supply = <&panel_vddi_poc_1p8>;
>>   
>> +		te-gpios = <&tlmm 30 GPIO_ACTIVE_HIGH>;
> 
> Isn't it GPIO 10?

The datasheet says that both 10 and 30 are TE GPIOs.

The downstream and mainline code describes gpio 30 as ESD check and as 
you write. So generally it seems to be confirmed that 10 is TE (same as 
for other sdm845 devices as Samsung S9).

Will be fixed in the next patchset version.

Thank you



> 
>>   		reset-gpios = <&tlmm 6 GPIO_ACTIVE_LOW>;
>>   
>>   		pinctrl-0 = <&panel_default>;
>>
>> -- 
>> 2.51.0
>>
>>
> 

-- 
David Heidelberg