linux-kernel - Re: [PATCH 1/2] rust: pin-init: fix broken rust doc link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DDK2SA1D77HM.38KOTOTF8FJXI@kernel.org>
Date: Thu, 16 Oct 2025 23:47:47 +0200
From: "Benno Lossin" <lossin@...nel.org>
To: "Miguel Ojeda" <miguel.ojeda.sandonis@...il.com>
Cc: "Miguel Ojeda" <ojeda@...nel.org>, "Alex Gaynor"
 <alex.gaynor@...il.com>, "Boqun Feng" <boqun.feng@...il.com>, "Gary Guo"
 <gary@...yguo.net>, Björn Roy Baron
 <bjorn3_gh@...tonmail.com>, "Andreas Hindborg" <a.hindborg@...nel.org>,
 "Alice Ryhl" <aliceryhl@...gle.com>, "Trevor Gross" <tmgross@...ch.edu>,
 "Danilo Krummrich" <dakr@...nel.org>, "Fiona Behrens" <me@...enk.dev>,
 "Alban Kurti" <kurti@...icto.ai>, <rust-for-linux@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] rust: pin-init: fix broken rust doc link

On Thu Oct 16, 2025 at 11:24 PM CEST, Miguel Ojeda wrote:
> On Thu, Oct 16, 2025 at 11:17 PM Benno Lossin <lossin@...nel.org> wrote:
>>
>> Rust 1.92.0 warns when building the documentation that [`PinnedDrop`] is
>> an invalid reference. This is correct and it's weird that it didn't warn
>> before, so fix the link.
>
> It is because it is hidden -- I have patches to fix this (it is not
> just in pin-init but elsewhere too), but I am waiting for confirmation
> on whether this is actually intentional behavior:
>
>     https://github.com/rust-lang/rust/pull/147153#issuecomment-3395484636
>
> From the early reply I got, it seems it is not, so it may be that it is "fixed".
>
> Personally, I think it is useful, so I hope they keep it, even if as a
> new opt-in option or similar.
>
> Of course, we can land this patch since it does not matter either way,
> but please add a note with the above in the commit message if you land
> it.

Thanks a lot for the added context! I will add it when applying. The
`__pinned_drop!` macro will be gone with the syn patches this cycle, so
in this case, we don't care what the resolution will be.

---
Cheers,
Benno