linux-kernel - Re: [PATCH v2 2/6] dt-bindings: media: camss: Add qcom,kaanapali-camss binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aeb65634-aa56-425a-9488-aea2a46efd95@kernel.org>
Date: Thu, 16 Oct 2025 07:51:09 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: "Rob Herring (Arm)" <robh@...nel.org>,
 Hangxiang Ma <hangxiang.ma@....qualcomm.com>
Cc: Loic Poulain <loic.poulain@....qualcomm.com>,
 trilok.soni@....qualcomm.com, Mauro Carvalho Chehab <mchehab@...nel.org>,
 linux-arm-msm@...r.kernel.org, Todor Tomov <todor.too@...il.com>,
 Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Robert Foss <rfoss@...nel.org>,
 linux-media@...r.kernel.org, Atiya Kailany <atiya.kailany@....qualcomm.com>,
 Andi Shyti <andi.shyti@...nel.org>, tingwei.zhang@....qualcomm.com,
 Bryan O'Donoghue <bryan.odonoghue@...aro.org>, aiqun.yu@....qualcomm.com,
 linux-kernel@...r.kernel.org, Jingyi Wang <jingyi.wang@....qualcomm.com>,
 linux-i2c@...r.kernel.org, yijie.yang@....qualcomm.com,
 devicetree@...r.kernel.org
Subject: Re: [PATCH v2 2/6] dt-bindings: media: camss: Add
 qcom,kaanapali-camss binding

On 15/10/2025 06:37, Rob Herring (Arm) wrote:
> 
> On Tue, 14 Oct 2025 19:56:02 -0700, Hangxiang Ma wrote:
>> Add bindings for qcom,kaanapali-camss in order to support the camera
>> subsystem for Kaanapali.
>>
>> Signed-off-by: Hangxiang Ma <hangxiang.ma@....qualcomm.com>
>> ---
>>  .../bindings/media/qcom,kaanapali-camss.yaml       | 494 +++++++++++++++++++++
>>  1 file changed, 494 insertions(+)
>>
> 
> My bot found errors running 'make dt_binding_check' on your patch:
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> Documentation/devicetree/bindings/media/qcom,kaanapali-camss.example.dts:25:18: fatal error: dt-bindings/clock/qcom,kaanapali-camcc.h: No such file or directory
>    25 |         #include <dt-bindings/clock/qcom,kaanapali-camcc.h>
>       |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


This patch has completely unnecessary dependencies which makes it
untestable and unmergeable.

I won't be reviewing it.

Best regards,
Krzysztof