linux-kernel - RE: [PATCH v6 1/3] dt-bindings: thermal: samsung: Adjust '#thermal-sensor-cells' to 1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <001e01dc3e61$38c3fb30$aa4bf190$@samsung.com>
Date: Thu, 16 Oct 2025 14:53:30 +0900
From: 손신 <shin.son@...sung.com>
To: "'Krzysztof Kozlowski'" <krzk@...nel.org>, "'Bartlomiej Zolnierkiewicz'"
	<bzolnier@...il.com>, "'Rafael J . Wysocki'" <rafael@...nel.org>, "'Daniel
 Lezcano'" <daniel.lezcano@...aro.org>, "'Zhang Rui'" <rui.zhang@...el.com>,
	"'Lukasz	Luba'" <lukasz.luba@....com>, "'Rob Herring'" <robh@...nel.org>,
	"'Conor Dooley'" <conor+dt@...nel.org>, "'Alim Akhtar'"
	<alim.akhtar@...sung.com>, "'Henrik Grimler'" <henrik@...mler.se>
Cc: <linux-pm@...r.kernel.org>, <linux-samsung-soc@...r.kernel.org>,
	<devicetree@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v6 1/3] dt-bindings: thermal: samsung: Adjust
 '#thermal-sensor-cells' to 1

Hello Krzysztof Kozlowski,

> -----Original Message-----
> From: Krzysztof Kozlowski [mailto:krzk@...nel.org]
> Sent: Friday, October 10, 2025 9:44 PM
> To: Shin Son <shin.son@...sung.com>; Bartlomiej Zolnierkiewicz
> <bzolnier@...il.com>; Rafael J . Wysocki <rafael@...nel.org>; Daniel
> Lezcano <daniel.lezcano@...aro.org>; Zhang Rui <rui.zhang@...el.com>;
> Lukasz Luba <lukasz.luba@....com>; Rob Herring <robh@...nel.org>; Conor
> Dooley <conor+dt@...nel.org>; Alim Akhtar <alim.akhtar@...sung.com>;
> Henrik Grimler <henrik@...mler.se>
> Cc: linux-pm@...r.kernel.org; linux-samsung-soc@...r.kernel.org;
> devicetree@...r.kernel.org; linux-arm-kernel@...ts.infradead.org; linux-
> kernel@...r.kernel.org
> Subject: Re: [PATCH v6 1/3] dt-bindings: thermal: samsung: Adjust
> '#thermal-sensor-cells' to 1
> 
> On 30/09/2025 02:51, Shin Son wrote:
> >          reg:
> >            minItems: 1
> >            maxItems: 1
> > +        '#thermal-sensor-cells':
> > +          const: 0
> > +
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            const: samsung,exynosautov920-tmu
> > +    then:
> > +      properties:
> > +        clocks:
> > +          minItems: 1
> 
> You can drop minItems. Existing binding has it unnecessarily.

Ok, I'll drop it.

> 
> > +          maxItems: 1
> 
> You also need clock-names restriction, just like clocks or just ": false".
>

I'll add the clock-names restriction. Thanks.

 
> > +        reg:
> > +          minItems: 1
> 
> This also drop.

Ok, I'll also drop it.

 
> > +          maxItems: 1
> > +        '#thermal-sensor-cells':
> > +          const: 1
> >
> 
> 
> Rest looks fine, so with changes above:
> 
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Ok, I'll add the reviewer tag on the patches.

> 
> 
> Best regards,
> Krzysztof

Best regards,
Shin Son