linux-kernel - Re: [PATCH v2] power: supply: intel_dc_ti

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a5dc35d1-497e-40bd-b729-0ed9695311ff@kernel.org>
Date: Thu, 16 Oct 2025 08:29:50 +0200
From: Jiri Slaby <jirislaby@...nel.org>
To: sre@...nel.org
Cc: linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
 Linus Walleij <linus.walleij@...aro.org>, Hans de Goede <hansg@...nel.org>,
 Sebastian Reichel <sebastian.reichel@...labora.com>
Subject: Re: [PATCH v2] power: supply: intel_dc_ti_battery: fix 64bit
 divisions

OK, now I came across 20251015075957.8F40620057@...n.mk-sys.cz, so no 
need for this one...

On 16. 10. 25, 8:27, Jiri Slaby (SUSE) wrote:
> On 32bit builds, I get:
> ERROR: modpost: "__udivdi3" [drivers/power/supply/intel_dc_ti_battery.ko] undefined!
> 
> This is due to 64bit ktime divisions. Fix both by using div_u64().
> 
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@...nel.org>
> Fixes: 8c5795fe5527 ("power: supply: Add new Intel Dollar Cove TI battery driver")
> ---
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Cc: Hans de Goede <hansg@...nel.org>
> Cc: Sebastian Reichel <sebastian.reichel@...labora.com>
> 
> [v2] added Signed-off-by.
> ---
>   drivers/power/supply/intel_dc_ti_battery.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/power/supply/intel_dc_ti_battery.c b/drivers/power/supply/intel_dc_ti_battery.c
> index 56b0c92e9d28..3d38106b638b 100644
> --- a/drivers/power/supply/intel_dc_ti_battery.c
> +++ b/drivers/power/supply/intel_dc_ti_battery.c
> @@ -141,7 +141,7 @@ static int dc_ti_battery_get_voltage_and_current_now(struct power_supply *psy, i
>   	if (ret)
>   		goto out_err;
>   
> -	cnt_start_usec = ktime_get_ns() / NSEC_PER_USEC;
> +	cnt_start_usec = div_u64(ktime_get_ns(), NSEC_PER_USEC);
>   
>   	/* Read Vbat, convert IIO mV to power-supply ųV */
>   	ret = iio_read_channel_processed_scale(chip->vbat_channel, volt, 1000);
> @@ -149,7 +149,7 @@ static int dc_ti_battery_get_voltage_and_current_now(struct power_supply *psy, i
>   		goto out_err;
>   
>   	/* Sleep at least 3 sample-times + slack to get 3+ CC samples */
> -	now_usec = ktime_get_ns() / NSEC_PER_USEC;
> +	now_usec = div_u64(ktime_get_ns(), NSEC_PER_USEC);
>   	sleep_usec = 3 * SMPL_INTVL_US + SLEEP_SLACK_US - (now_usec - cnt_start_usec);
>   	if (sleep_usec > 0 && sleep_usec < 1000000)
>   		usleep_range(sleep_usec, sleep_usec + SLEEP_SLACK_US);


-- 
js
suse labs