linux-kernel - RE: [PATCH rc] iommufd/selftest: Fix ioctl return value in _test_cmd_trigger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BN9PR11MB5276834E90A7990269EBBF608CE9A@BN9PR11MB5276.namprd11.prod.outlook.com>
Date: Thu, 16 Oct 2025 07:47:20 +0000
From: "Tian, Kevin" <kevin.tian@...el.com>
To: Nicolin Chen <nicolinc@...dia.com>, "jgg@...dia.com" <jgg@...dia.com>
CC: "shuah@...nel.org" <shuah@...nel.org>, "alessandro.zanni87@...il.com"
	<alessandro.zanni87@...il.com>, "iommu@...ts.linux.dev"
	<iommu@...ts.linux.dev>, "linux-kselftest@...r.kernel.org"
	<linux-kselftest@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH rc] iommufd/selftest: Fix ioctl return value in
 _test_cmd_trigger_vevents()

> From: Nicolin Chen <nicolinc@...dia.com>
> Sent: Wednesday, October 15, 2025 5:49 AM
> 
> The ioctl returns 0 upon success, so !0 returning -1 breaks the selftest.
> 
> Drop the '!' to fix it.
> 
> Fixes: 1d235d849425 ("iommu/selftest: prevent use of uninitialized variable")
> Signed-off-by: Nicolin Chen <nicolinc@...dia.com>

Reviewed-by: Kevin Tian <kevin.tian@...el.com>